open websocket on same path as page #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the critical piece to let you serve code-server proxied under a path. Otherwise if you proxy e.g. `/editor/` thru to `http://localhost:8000`, everything works fine except the websocket connection is still opened to `/`
|
The app with this works minimally when proxied. There are some 404ing assets, which I'm not immediately sure how to fix:
Basically all of those should be |
|
Did these assets 404 prior to the WebSocket fix? |
|
The only one I can confirm is |
|
This issue fixed: |
Closed
andreimc
added a commit
to devonlineco/code-server
that referenced
this pull request
Mar 11, 2019
* upstream/master: (35 commits) Dockerfile: use relative path instead of $PWD for CMD Update docker oneliner and fix clone task Clone exact vscode release branch when build task (coder#167) Add -t flag to docker example (coder#181) Reverts parts of my last PR (coder#177) Fix build and Dockerfile issues (coder#176) Add nginx reverse proxy guide for selfhosted Use a timing-safe equality check for passwords (coder#133) Open websocket on same path as page (coder#149) Adhere to XDG base directory spec for dataDir and logDir (coder#156) Improve github issue template (coder#162) Fix typo: environemnt -> environment (coder#159) Add back web class Move upx compression behind an env flag ci: enable travis npm cache (coder#110) Improve .dockerignore (coder#111) Feature/1.32.0 update (coder#117) Update grammar on README (coder#139) inital -> initial (coder#135) Handle arch in dockerfile and add PR template (coder#109) ...
code-asher
pushed a commit
that referenced
this pull request
Jun 19, 2019
This is the critical piece to let you serve code-server proxied under a path. Otherwise if you proxy e.g. `/editor/` thru to `http://localhost:8000`, everything works fine except the websocket connection is still opened to `/`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the critical piece to let you serve code-server proxied under a
path. Otherwise if you proxy e.g.
/editor/thru tohttp://localhost:8000, everything works fine except the websocketconnection is still opened to
/