Skip to content

Handle URLs more robustly #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mingjun97 opened this issue Mar 9, 2019 · 1 comment
Closed

Handle URLs more robustly #160

mingjun97 opened this issue Mar 9, 2019 · 1 comment

Comments

@mingjun97
Copy link

  • code-server version: docker default version
  • OS Version: docker CE inside Debian

Steps to Reproduce

  1. Establish reverse proxy via nginx with mapping https://xxxx/ide/ to http://localhost:8443/
  2. The page showed GET // Failed.

I also tried other configurations. But this configuration seems to be the most correct. I guess the URL handler should be more robust to handle URLs like this.
@NGTmeaty
Copy link
Contributor

NGTmeaty commented Mar 9, 2019

Open PR #149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NGTmeaty @kylecarbs @mingjun97