Skip to content

refactor(ci): use release in branch release name #5352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Jul 18, 2022

Description

This changes the release process to use release/v0.0.0 for the branch name instead of v0.0.0. We need to do this because GitHub added a rule which prevents use from tagging a release with same name as a branch.

We ran into this with the 4.5.0 release.

@jsjoeio jsjoeio requested a review from a team July 18, 2022 19:11
@jsjoeio jsjoeio self-assigned this Jul 18, 2022
@github-actions
Copy link

✨ code-server docs for PR #5352 is ready! It will be updated on every commit.

@jsjoeio jsjoeio added ci Issues related to ci chore Related to maintenance or clean up labels Jul 18, 2022
@jsjoeio jsjoeio added this to the 4.5.1 milestone Jul 18, 2022
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have had other issues with tag and branch name collisions in the past as well so this is fantastic. I love the release/ prefix.

@jsjoeio jsjoeio enabled auto-merge (squash) July 18, 2022 19:15
@jsjoeio jsjoeio temporarily deployed to npm July 18, 2022 19:16 Inactive
@github-actions
Copy link

✨ code-server dev build published to npm for PR #5352!

  • Last publish status: success
  • Commit: 0d2d715

To install in a local project, run:

npm install @coder/code-server-pr@5352

To install globally, run:

npm install -g @coder/code-server-pr@5352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up ci Issues related to ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants