Skip to content

[Bug]: Code-Server Version is still 4.4.0 after upgrading to 4.5.0 #5316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks done
balajib-b opened this issue Jul 2, 2022 · 10 comments
Closed
4 tasks done

[Bug]: Code-Server Version is still 4.4.0 after upgrading to 4.5.0 #5316

balajib-b opened this issue Jul 2, 2022 · 10 comments
Assignees
@jsjoeio
Labels
bug Something isn't working high-priority This issue needs to be resolved ASAP
Milestone
4.5.1

Comments

@balajib-b
Copy link

balajib-b commented Jul 2, 2022 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

OS/Web Information

  • Web Browser: Chrome
  • Local OS: Kubuntu 20.04
  • Remote OS: Ubuntu 20.04
  • Remote Architecture: arm64
  • code-server --version:4.5.0

Steps to Reproduce

  1. click menu
  2. click Help
  3. click About

Expected

version : 4.5.0

Actual

Version 4.4.0

Logs

No response

Screenshot/Video

image

Does this issue happen in VS Code or GitHub Codespaces?

  • I cannot reproduce this in VS Code.
  • I cannot reproduce this in GitHub Codespaces.

Are you accessing code-server over HTTPS?

  • I am using HTTPS.

Notes

No response
@balajib-b balajib-b added bug Something isn't working triage This issue needs to be triaged by a maintainer labels Jul 2, 2022
@thediveo
Copy link

thediveo commented Jul 3, 2022

Confirming for arm64 .deb on Ubuntu 21.04 arm64: systemctl status code-server shows v4.5.0 in the logs, but even after clearing browser caches the web UI always shows v4.4.0 and the wrong commit hash.

@AalmanSadath
Copy link

Confirmed on Debian for arm64 and amd64 with individual .deb packages as well as using install script.

@GuillaumeLazar
Copy link

GuillaumeLazar commented Jul 6, 2022 •
edited
Loading

Same issue after upgrading from v4.4.0 to v4.5.0 using the install.sh script on Ubuntu 22.04 LTS (amd64).

$ dpkg -s code-server | grep Version
Version: 4.5.0

code-server "About popup" displays:

code-server: v4.4.0
Code: 1.68.1
Commit: 30d9c6cd9483b2cc586687151bcbcd635f373630

@LCMilstein
Copy link

Same issue trying multiple install approaches, including the GUI in Docker on Synology

@benz0li
Copy link
Contributor

benz0li commented Jul 8, 2022

@jsjoeio Also reproducible at https://vscode-r.jupyter.b-data.ch with image R (base:test) + code-server as your account is still whitelisted.

JupyterLab > Terminal:

$ code-server --version
4.5.0 02b9d7ee856e31d9008d1ff24a175ff03b49010e with Code 1.68.1

code-server > Help > About:

code-server_Help_About

@benz0li
Copy link
Contributor

benz0li commented Jul 8, 2022

Cross reference: #5326

@somnisomni
Copy link

somnisomni commented Jul 16, 2022 •
edited
Loading

In released code-server-4.5.0-linux-amd64.tar.gz/lib/vscode/product.json, seems like some have-to-be-changed properties remain as same as v4.4.0 one.

image

@jsjoeio
Copy link
Contributor

jsjoeio commented Jul 18, 2022

I see this as well. I think there was a "race condition" that happened with the 4.5.0 release. We normally create a branch called v4.5.0 for the release then tag it the same but GH added something that doesn't allow them to be the same anymore.

#5352 should

I'm testing right now before releasing 4.5.1 and still see this issue so we may need to fix this before releasing:

image

@jsjoeio jsjoeio added high-priority This issue needs to be resolved ASAP and removed triage This issue needs to be triaged by a maintainer labels Jul 18, 2022
@jsjoeio jsjoeio added this to the 4.5.1 milestone Jul 18, 2022
@jsjoeio jsjoeio self-assigned this Jul 18, 2022
@jsjoeio jsjoeio mentioned this issue Jul 18, 2022
Merged
2 tasks
jsjoeio added a commit that referenced this issue Jul 19, 2022
@jsjoeio
fix(ci): add package.json.version to code cachekey
3cd3475 
Before this, creating a release sometimes prevented vscode from
rebuilding and using the cache instead. Now we use the
package.json.version in the cache key to "bust" the cache if the
package.json version is updated (aka a release).

Fixes #5316
@jsjoeio
Copy link
Contributor

jsjoeio commented Jul 19, 2022 •
edited
Loading

We think this is because CI hit the cache when releasing 4.5.0 so it didn't rebuild leading to this issue.

I will test, verify and then close if it fixes it.

See 3cd3475

@jsjoeio
Copy link
Contributor

jsjoeio commented Jul 19, 2022

fixed via 3cd3475

version

This will be updated in the next release.

@jsjoeio jsjoeio closed this as completed Jul 19, 2022
jsjoeio added a commit that referenced this issue Jul 19, 2022
@jsjoeio @code-asher
release: 4.5.1 (#5354)
f4fc2eb 
* chore(release): bump version to 4.5.1

* chore: bump helm chart

* chore: update CHANGELOG

* Revert "chore: bump helm chart"

This reverts commit 703b03b.

* chore: bump helm chart to 3.0.0

* revert: remove bad change to manifes.json icon

* fix(ci): add package.json.version to code cachekey

Before this, creating a release sometimes prevented vscode from
rebuilding and using the cache instead. Now we use the
package.json.version in the cache key to "bust" the cache if the
package.json version is updated (aka a release).

Fixes #5316

* Update .github/workflows/ci.yaml

Co-authored-by: Asher <[email protected]>

* fixup: formatting

* Revert "refactor: remove version check e2e test"

This reverts commit b23c398.

Co-authored-by: Asher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsjoeio jsjoeio

Labels
bug Something isn't working high-priority This issue needs to be resolved ASAP
Projects
None yet
Milestone
4.5.1
Development

No branches or pull requests
8 participants
@jsjoeio @thediveo @GuillaumeLazar @LCMilstein @benz0li @balajib-b @somnisomni @AalmanSadath