Skip to content

Commit 23a1878

Browse files
authored
refactor(ci): use release in branch release name (#5352)
1 parent 033cdf2 commit 23a1878

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

.github/workflows/npm-brew.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131
uses: dawidd6/action-download-artifact@v2
3232
id: download
3333
with:
34-
branch: v${{ steps.version.outputs.version }}
34+
branch: release/v${{ steps.version.outputs.version }}
3535
workflow: ci.yaml
3636
workflow_conclusion: completed
3737
name: "npm-package"

docs/MAINTAINING.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,8 @@ If you're the current release manager, follow these steps:
164164

165165
### Publishing a release
166166

167-
1. Create a new branch called `v0.0.0` (replace 0s with actual version aka v4.5.0)
167+
1. Create a new branch called `release/v0.0.0` (replace 0s with actual version aka v4.5.0)
168+
1. If you don't do this, the `npm-brew` GitHub workflow will fail. It looks for the release artifacts under the branch pattern.
168169
1. Run `yarn release:prep` and type in the new version (e.g., `3.8.1`)
169170
1. GitHub Actions will generate the `npm-package`, `release-packages` and
170171
`release-images` artifacts. You do not have to wait for this step to complete

0 commit comments

Comments
 (0)