Skip to content

Add flags for customizing user data dir and extensions dir #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 3, 2019
Merged

Add flags for customizing user data dir and extensions dir #420

merged 2 commits into from
Apr 3, 2019

Conversation

kylecarbs
Copy link
Member

Mirrors vscode CLI options --user-data-dir and --extensions-dir.

Allows inheriting local VS Code configuration (eg. --user-data-dir ~/.config/User --extensions-dir ~/.vscode/extensions).

@kylecarbs kylecarbs requested a review from code-asher as a code owner April 3, 2019 21:47
ammario
ammario reviewed Apr 3, 2019
View reviewed changes
Copy link
Member

@ammario ammario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should say something about this high up in the README

@kylecarbs
Copy link
Member Author

@ammario Going to add a section about compatibility with VS Code in another PR

@code-asher code-asher merged commit 4af84fc into master Apr 3, 2019
@code-asher code-asher deleted the extdir branch April 3, 2019 22:07
@nol166 nol166 mentioned this pull request Apr 3, 2019
Closed
andreimc added a commit to devonlineco/code-server that referenced this pull request Apr 4, 2019
@andreimc
Merge remote-tracking branch 'upstream/master'
6eb70ca 
* upstream/master:
  Fix error when shared process exits with null
  Add flags for customizing user data dir and extensions dir (coder#420)
  Initialize backup service (coder#419)
  Add port in use message (coder#418)
  Improve CI caching (coder#416)
  Update notes title
code-asher pushed a commit that referenced this pull request Jun 19, 2019
@kylecarbs @code-asher
Add flags for customizing user data dir and extensions dir (#420)
3a4c08b 
* Add flags for customizing extensions directory

* Update @coder/nbin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammario ammario ammario approved these changes

@code-asher code-asher code-asher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kylecarbs @ammario @code-asher