Skip to content

Add port in use message #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 3, 2019
Merged

Add port in use message #418

merged 7 commits into from
Apr 3, 2019

Conversation

nol166
Copy link
Contributor

@nol166 nol166 commented Apr 3, 2019

Describe in detail the problem you had and how this PR fixes it

Add better error handling and informative error message for when a port is in use

Is there an open issue you can link to?

#408

@nol166 nol166 requested a review from code-asher April 3, 2019 18:14
@nol166 nol166 requested a review from kylecarbs as a code owner April 3, 2019 18:14
@nol166 nol166 requested a review from code-asher April 3, 2019 19:26
@code-asher code-asher merged commit 2175153 into master Apr 3, 2019
@code-asher code-asher deleted the add-port-message branch April 3, 2019 20:50
andreimc added a commit to devonlineco/code-server that referenced this pull request Apr 4, 2019
* upstream/master:
  Fix error when shared process exits with null
  Add flags for customizing user data dir and extensions dir (coder#420)
  Initialize backup service (coder#419)
  Add port in use message (coder#418)
  Improve CI caching (coder#416)
  Update notes title
code-asher pushed a commit that referenced this pull request Jun 19, 2019
* Add clear error message if port is in use

* Add bold function for text/numbers

* remove unused dependency:

* remove unused line break

* Change logger message

* Use NodeJS.ErrnoException type

* Add back check for error code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants