Initialize backup service #419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-asher
force-pushed
the
fix/backup-service
branch
from
eb6db76 to
1106f4d
Compare
|
LGTM |
kylecarbs
approved these changes
Apr 3, 2019
code-asher
force-pushed
the
fix/backup-service
branch
from
1106f4d to
280e38d
Compare
code-asher
added a commit
that referenced
this pull request
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is the best way to handle it, but this creates the backup workspace file. It's mostly just to prevent the errors from appearing when the backup workspace file doesn't exist or is invalid since we're not actually using this anywhere (but we probably should).
There is also the history service that would probably be good to add, and maybe some others. It's possible we might want to try to include from
appinstead ofworkbench.mainbut I believe we tried that before and it didn't go super well. It's possible we just need to go through and make sure everything provided there is re-implemented on our side.