chore(dev): migrate away from parcel

[jsjoeio]

This PR migrates us away from Parcel by using tsc and browserify to accomplish the same thing.

Originally, we needed to upgrade Parcel from v1 to v2 due to maintainers deprecating v1 and a bunch of security vulnerabilities that we couldn't patch in v1. We were going to use v2 but it has breaking changes. So we decided to replace it with browserify which is a bit more lightweight and does the same thing.

Changes

• remove parcel
• use tsc to compile .ts files and browserify to bundle a few files used in the browser
• reference css files directly in HTML instead of including with js bundles
• remove minification of browser files (issues with es2015+ support using browserify plugin tinyify)
• add codecov.yml which allows us to override some default settings

Screenshot

Screenshot after building and running locally

Checklist

• updated CHANGELOG.md

Related

• chore(dev): remove parcel #3614

[codecov]

Codecov Report

Merging #3578 (684fe6c) into main (fbba8e8) will decrease coverage by 1.47%.
The diff coverage is 33.33%.

❗ Current head 684fe6c differs from pull request most recent head 5d4e08e. Consider uploading reports for the commit 5d4e08e to get more accurate results

@@            Coverage Diff             @@
##             main    #3578      +/-   ##
==========================================
- Coverage   60.67%   59.19%   -1.48%     
==========================================
  Files          35       35              
  Lines        1790     1784       -6     
  Branches      404      361      -43     
==========================================
- Hits         1086     1056      -30     
- Misses        562      612      +50     
+ Partials      142      116      -26     

Impacted Files	Coverage Δ
src/browser/pages/vscode.ts	0.00% <0.00%> (ø)
src/browser/register.ts	100.00% <ø> (ø)
src/browser/pages/login.ts	100.00% <100.00%> (+100.00%)	⬆️
src/node/wrapper.ts	22.07% <0.00%> (-11.05%)	⬇️
src/node/vscode.ts	19.48% <0.00%> (-8.02%)	⬇️
src/node/plugin.ts	64.60% <0.00%> (-3.59%)	⬇️
src/node/routes/login.ts	40.74% <0.00%> (-1.86%)	⬇️
src/node/app.ts	69.04% <0.00%> (-1.69%)	⬇️
src/node/util.ts	69.27% <0.00%> (-1.68%)	⬇️
src/node/http.ts	34.92% <0.00%> (-1.15%)	⬇️
... and 15 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbba8e8...5d4e08e. Read the comment docs.

[jsjoeio]

Currently blocked due to the Build failing due to parcel build in v2 not working the same as in v1.

Filed an issue upstream here but would love any help/suggestions.

[jawnsy]

A lot of changes in the deps, it's a good thing we have good test coverage!

[jsjoeio]

Turns out this only semi-works.

yarn watch isn't actually working and the end-to-end tests are failing. I'm going to explore the alternative, switching to tsc instead of parcel

[jsjoeio]

WIP: https://github.com/cdr/code-server/tree/jsjoeio/remove-parcel

Having issues getting our code to load in the browser after compiling with tsc and then using browserify.

Ideally, it should be easy:

• take browser-related .ts files
• compile to .js
• make browser-compatbile
• load via <script > tags in .html files

The adventure continues next week.

[devongovett]

Anything I can help with to upgrade you to Parcel 2? What issues did you run into with it?

[jsjoeio]

Hey @devongovett - super kind of you to offer to help — thank you!

I wish I took better notes when I was trying to upgrade to Parcel 2. I filed two issues (parcel-bundler/parcel#6433 and parcel-bundler/parcel#6433) which did help but there were other issues we couldn't get past.

All I do remember was something changed between Parcel 1 and Parcel 2 with how TypeScript files were bundled and we couldn't get it working with Parcel 2. There also weren't TypeScript typings, which was a bit of a bummer (but I think that's being worked on? parcel-bundler/parcel#3912)

Regardless, it made us realize that we really only needed to bundle a few files and it was probably overkill asking Parcel to do it for us. We ended up using tsc and browserify and it turned out to be very simple (see migration PR here #3614).

Thanks again for offering to help! Can't tell you how much we appreciate it.

[devongovett]

Yes, TS definitions for the API are in progress: parcel-bundler/parcel#6484

Anyway, if you do figure out what the problem was I'm happy to help. Ideally Parcel should work fine for cases like this.

[jsjoeio]

❗ Current head 684fe6c differs from pull request most recent head 5d4e08e. Consider uploading reports for the commit 5d4e08e to get more accurate results

How to fix:

1. Get commit (5d4e08e)
2. Check out locally git checkout 5d4e08e390f14ebdd62a6595a1851897a1377273
3. Run unit tests to generate output yarn test:unit
4. Run coverage yarn coverage

Actually, that should work but I'm running into an issue which appears to be upstraem

[jsjoeio]

I'm going to try @code-asher's idea tomorrow and create a new branch and PR. I will copy over everything too.

[jsjoeio]

Closing in favor of #3658