Skip to content

chore(dev): remove parcel #3614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2021
Merged

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Jun 15, 2021

After trying to fix many issues with upgrading to Parcel 2, we're thinking it may be easier to remove it completely.

Checklist

  • address comments
  • clean up commits
  • update CHANGELOG.md

@jsjoeio jsjoeio self-assigned this Jun 15, 2021
@jsjoeio jsjoeio added the chore Related to maintenance or clean up label Jun 15, 2021
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-3308 lines, I like it.

@jsjoeio jsjoeio force-pushed the jsjoeio/remove-parcel branch from edda6a7 to 63e8c96 Compare June 16, 2021 17:30
@jsjoeio jsjoeio marked this pull request as ready for review June 16, 2021 17:31
@jsjoeio jsjoeio requested a review from a team as a code owner June 16, 2021 17:31
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Jun 16, 2021

@code-asher ready for a second review 🎉

@jsjoeio jsjoeio force-pushed the jsjoeio/remove-parcel branch 2 times, most recently from bc349b5 to 43c21fb Compare June 17, 2021 22:59
@jsjoeio jsjoeio force-pushed the jsjoeio/remove-parcel branch from 43c21fb to 7afdcb4 Compare June 17, 2021 23:01
@jsjoeio jsjoeio requested a review from code-asher June 17, 2021 23:01
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@jsjoeio jsjoeio merged commit 11fde7f into jsjoeio/upgrade-parcel Jun 18, 2021
@jsjoeio jsjoeio deleted the jsjoeio/remove-parcel branch June 18, 2021 23:33
@jsjoeio jsjoeio restored the jsjoeio/remove-parcel branch June 22, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants