Skip to content

fix(security): update css-what, glob-parent, trim-newlines #3563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Jun 8, 2021

This PR fixes the following security vulnerabilities:

Checklist

  • updated CHANGELOG.md

@jsjoeio jsjoeio added the security Security related label Jun 8, 2021
@jsjoeio jsjoeio added this to the 3.11.0 milestone Jun 8, 2021
@jsjoeio jsjoeio self-assigned this Jun 8, 2021
@jsjoeio jsjoeio requested a review from a team as a code owner June 8, 2021 00:03
@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #3563 (6f2e8c9) into main (ecbef27) will not change coverage.
The diff coverage is n/a.

❗ Current head 6f2e8c9 differs from pull request most recent head 9652e65. Consider uploading reports for the commit 9652e65 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3563   +/-   ##
=======================================
  Coverage   59.21%   59.21%           
=======================================
  Files          35       35           
  Lines        1709     1709           
  Branches      379      379           
=======================================
  Hits         1012     1012           
  Misses        559      559           
  Partials      138      138           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecbef27...9652e65. Read the comment docs.

@oxy
Copy link

oxy commented Jun 8, 2021

This broke parcel-bundler :(
We're likely either going to have to ignore the vuln or move to parcel v2, which is still in beta months after v1 was deprecated :(

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Jun 8, 2021

We're likely either going to have to ignore the vuln or move to parcel v2

Shoot :( I wonder how easy/difficult that will be. Do you have a preference on which approach we take?

@code-asher
Copy link
Member

Could also consider removing Parcel and just compile with plain tsc using the UMD target. We would need a loader like require.js to handle the loading on the browser side.

I don't believe we make use of any other Parcel features other than the loading.

@jsjoeio jsjoeio marked this pull request as draft June 8, 2021 20:52
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Jun 9, 2021

Closing in favor of #3586 and #3578

@jsjoeio jsjoeio closed this Jun 9, 2021
@jsjoeio jsjoeio deleted the jsjoeio/fix-vulnerabilities branch June 9, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security Security related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants