chore: run builds on pull requests #2866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Run builds when changes are pushed to the main branch, or for pull requests opened against the main branch. This is a subtle change in behavior because, previously, builds would've run on pushes to any branch, regardless if a pull request is open yet. * Update to GitHub actions/checkout v2, which performs a shallow clone by default, which should speed up the build.
code-asher
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requests opened against the main branch. This is a subtle change
in behavior because, previously, builds would've run on pushes to
any branch, regardless if a pull request is open yet.
clone by default, which should speed up the build.
Closes: #2559 (:crossed_fingers:)
--
I believe that this should work, since only one job receives secrets according to the workflow definition (unless there's an administrative setting somewhere for global secrets passed using environment variables). However, I think the only way to be certain is to merge this and then open a pull request from a fork. If this breaks things or doesn't work correctly, we can always revert and try again.