Skip to content

Commit c270570

Browse files
authored
chore: run builds on pull requests (#2866)
* Run builds when changes are pushed to the main branch, or for pull requests opened against the main branch. This is a subtle change in behavior because, previously, builds would've run on pushes to any branch, regardless if a pull request is open yet. * Update to GitHub actions/checkout v2, which performs a shallow clone by default, and should speed up the build. Closes: #2559
1 parent 7024851 commit c270570

File tree

1 file changed

+18
-10
lines changed

1 file changed

+18
-10
lines changed

.github/workflows/ci.yaml

+18-10
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,18 @@
11
name: ci
22

3-
on: [push]
3+
on:
4+
push:
5+
branches:
6+
- main
7+
pull_request:
8+
branches:
9+
- main
410

511
jobs:
612
fmt:
713
runs-on: ubuntu-latest
814
steps:
9-
- uses: actions/checkout@v1
15+
- uses: actions/checkout@v2
1016
- name: Run ./ci/steps/fmt.sh
1117
uses: ./ci/images/debian10
1218
with:
@@ -15,7 +21,7 @@ jobs:
1521
lint:
1622
runs-on: ubuntu-latest
1723
steps:
18-
- uses: actions/checkout@v1
24+
- uses: actions/checkout@v2
1925
- name: Run ./ci/steps/lint.sh
2026
uses: ./ci/images/debian10
2127
with:
@@ -28,7 +34,7 @@ jobs:
2834
PASSWORD: e45432jklfdsab
2935
CODE_SERVER_ADDRESS: http://localhost:8080
3036
steps:
31-
- uses: actions/checkout@v1
37+
- uses: actions/checkout@v2
3238
- name: Download release packages
3339
uses: actions/download-artifact@v2
3440
with:
@@ -55,7 +61,7 @@ jobs:
5561
release:
5662
runs-on: ubuntu-latest
5763
steps:
58-
- uses: actions/checkout@v1
64+
- uses: actions/checkout@v2
5965
- name: Run ./ci/steps/release.sh
6066
uses: ./ci/images/debian10
6167
with:
@@ -70,7 +76,7 @@ jobs:
7076
needs: release
7177
runs-on: ubuntu-latest
7278
steps:
73-
- uses: actions/checkout@v1
79+
- uses: actions/checkout@v2
7480
- name: Download npm package
7581
uses: actions/download-artifact@v2
7682
with:
@@ -90,7 +96,7 @@ jobs:
9096
needs: release
9197
runs-on: ubuntu-arm64-latest
9298
steps:
93-
- uses: actions/checkout@v1
99+
- uses: actions/checkout@v2
94100
- name: Download npm package
95101
uses: actions/download-artifact@v2
96102
with:
@@ -111,8 +117,10 @@ jobs:
111117
macos-amd64:
112118
needs: release
113119
runs-on: macos-latest
120+
# This job requires secrets, so can only run on the default branch
121+
if: github.ref == 'refs/heads/main'
114122
steps:
115-
- uses: actions/checkout@v1
123+
- uses: actions/checkout@v2
116124
- name: Download npm package
117125
uses: actions/download-artifact@v2
118126
with:
@@ -133,7 +141,7 @@ jobs:
133141
runs-on: ubuntu-latest
134142
needs: linux-amd64
135143
steps:
136-
- uses: actions/checkout@v1
144+
- uses: actions/checkout@v2
137145
- name: Download release package
138146
uses: actions/download-artifact@v2
139147
with:
@@ -153,7 +161,7 @@ jobs:
153161
runs-on: ubuntu-arm64-latest
154162
needs: linux-arm64
155163
steps:
156-
- uses: actions/checkout@v1
164+
- uses: actions/checkout@v2
157165
- name: Download release package
158166
uses: actions/download-artifact@v2
159167
with:

0 commit comments

Comments
 (0)