Skip to content

Make CI work on forks #2559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nhooyr opened this issue Jan 11, 2021 · 1 comment · Fixed by #2866
Closed

Make CI work on forks #2559

nhooyr opened this issue Jan 11, 2021 · 1 comment · Fixed by #2866
Labels
chore Related to maintenance or clean up enhancement Some improvement that isn't a feature
Milestone

Comments

@nhooyr
Copy link
Contributor

nhooyr commented Jan 11, 2021

Unfortunately github actions CI will only work on forks if there are no custom secrets.

So the npm package and docker image release process will have to be ran manually instead of via CI. Those are also in a separate workflow and github actions still won't run the workflow that does not depend on any secrets.

It's a worthy tradeoff to make it easier for contributors to get feedback on their changes.

@nhooyr nhooyr added the enhancement Some improvement that isn't a feature label Jan 11, 2021
@nhooyr nhooyr added this to the v3.8.1 milestone Jan 11, 2021
@nhooyr nhooyr self-assigned this Jan 11, 2021
@nhooyr nhooyr removed this from the v3.8.1 milestone Feb 5, 2021
@jawnsy
Copy link
Contributor

jawnsy commented Feb 25, 2021

This might be a new feature, but I think GitHub Actions supports running builds in forks with secrets, requiring approval before doing so (to avoid people trying to steal secrets using echo $ENV_VAR or whatever): https://docs.github.com/en/actions/reference/environments#environment-secrets

@jsjoeio jsjoeio added this to the v3.9.2 milestone Mar 10, 2021
jawnsy added a commit that referenced this issue Mar 12, 2021
* Run builds when changes are pushed to the main branch, or for pull
  requests opened against the main branch. This is a subtle change
  in behavior because, previously, builds would've run on pushes to
  any branch, regardless if a pull request is open yet.
* Update to GitHub actions/checkout v2, which performs a shallow
  clone by default, and should speed up the build.

Closes: #2559
@jsjoeio jsjoeio added the chore Related to maintenance or clean up label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up enhancement Some improvement that isn't a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants