Support proxying ports without separate sub-domains

[502647092]

Is there an existing issue for this?

• I have searched the existing issues

OS/Web Information

• Web Browser: EDGE
• Local OS: Windows
• Remote OS: Linux
• Remote Architecture: x64
• code-server --version: 4.12.0

Steps to Reproduce

config env
PROXY_DOMAIN: domain.ltd
VSCODE_PROXY_URI: https://{{port}}-code.domain.ltd

open https://{{port}}-code.domain.ltd redirect to coder-server

Expected

redirect to loca proxy port

Actual

redirect to coder-server

Logs

No response

Screenshot/Video

No response

Does this issue happen in VS Code or GitHub Codespaces?

• I cannot reproduce this in VS Code.
• I cannot reproduce this in GitHub Codespaces.

Are you accessing code-server over HTTPS?

• I am using HTTPS.

Notes

#5311

code-server/src/node/routes/domainProxy.ts

Lines 22 to 29 in 5708e6c

	const parts = domain.split(".")
	// There must be an exact match.
	const port = parts.shift()
	const proxyDomain = parts.join(".")
	if (!port || !req.args["proxy-domain"].includes(proxyDomain)) {
	return undefined
	}

maybe can use regex to match port
example
VSCODE_PROXY_URI {{port}}-code.domain.ltd
5140-code.domain.ltd match port to 5140

[code-asher]

Ah yeah the subdomain proxy requires that the port be the first and only part of the sub-domain, so something like {{port}}.code.domain.tld (with proxy-domain set to code.domain.tld) or {{port}}.domain.tld (with proxy-domain set to domain.tld) instead would work.

[502647092]

Ah yeah the subdomain proxy requires that the port be the first and only part of the sub-domain, so something like {{port}}.code.domain.tld (with proxy-domain set to code.domain.tld) or {{port}}.domain.tld (with proxy-domain set to domain.tld) instead would work.

Perhaps we can compromise and adopt the method I suggested, which can eliminate the need to apply for another wildcard SSL certificate.

[code-asher]

Sure, that seems like a good reason.

[code-asher]

This will make it into the next release but I am not sure it actually solves this particular problem. You still need separate (sub)domains for every single port.

5140-code.domain.ltd
5141-code.domain.ltd
5142-code.domain.ltd

This still requires a wildcard cert right?

The only way to not require multiple domains is to use the path-based proxy.

[oruharo]

I need it to run multiple code-servers on k8s.

• Two wildcard cert are required. -> *.cs1.domain.ltd, *.cs2.domain.ltd
  https://5140.cs1.domain.ltd
  https://5141.cs1.domain.ltd
  https://5140.cs2.domain.ltd
  https://5141.cs2.domain.ltd

• Only one wildcard cert is required. -> *.domain.ltd
  https://5140-cs1.domain.ltd
  https://5141-cs1.domain.ltd
  https://5140-cs2.domain.ltd
  https://5141-cs2.domain.ltd

[code-asher]

Ahhh I see! That use case makes sense.