use VSCODE_PROXY_URI for domainProxy, allow {{host}} replacement #6225
Conversation
this enables support for VSCODE_PROXY_URIs like https://code-{{port}}.{{host}}
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6225 +/- ##
==========================================
- Coverage 73.00% 72.61% -0.40%
==========================================
Files 30 30
Lines 1730 1749 +19
Branches 384 387 +3
==========================================
+ Hits 1263 1270 +7
- Misses 391 402 +11
- Partials 76 77 +1
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Nice work! Implementation looks solid to me but I think we should base this off the proxy-domain values rather than the environment variable (see below).
We should also consider adding some text to the proxy-domain help mentioning that you can use {{port}} and {{host}}.
|
@smerschjohann @code-asher Any Update on this Issue? |
|
@Vaibhav1919 Will be looking at the changes today. |
There was a problem hiding this comment.
Looks great! I think we just need to figure out what we want to do with regards to host vs hostname and we are good to go. There are also some formatting changes and I think we need to update some of the unit tests that test the --proxy-domain flag.
I like how the {{port}} is part of the output now if you do something like --proxy-domain test.com because it makes it very clear what exactly is being forwarded.
As a separate thing, I noticed that manually forwarding a port does not seem to use the proxy URI but this seems to be an existing bug so I will open a new issue for that.
|
I'm done, hopefully the pipeline tells us the same ;) |
|
Thanks again! |
|
No problem! |
Fixes #6218
Fixes #6195
this enables support for VSCODE_PROXY_URIs like https://code-{{port}}.{{host}}