Skip to content

[Feat]: make VSCODE_PROXY_URI use the subdomain proxy when it is enabled #5311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jsjoeio opened this issue Jun 30, 2022 · 1 comment · Fixed by #6115
Closed

[Feat]: make VSCODE_PROXY_URI use the subdomain proxy when it is enabled #5311

jsjoeio opened this issue Jun 30, 2022 · 1 comment · Fixed by #6115
Labels
enhancement Some improvement that isn't a feature

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Jun 30, 2022

What is your suggestion?

When VSCODE_PROXY_URI is enabled, use the subdomain proxy.

Why do you want this feature?

Popular extensions like Tabnine can't use relative paths and need to be able to talk to code-server on specific ports/paths in order to work correctly.

Are there any workarounds to get this functionality today?

Port forwarding but this isn't always possible.

Are you interested in submitting a PR for this?

Yes, with more context.

@jsjoeio jsjoeio added the enhancement Some improvement that isn't a feature label Jun 30, 2022
@jsjoeio jsjoeio added this to the On Deck - High Priority milestone Jun 30, 2022
@code-asher
Copy link
Member

code-asher commented Jun 30, 2022

We might also want a way to override this for cases like Coder where we already provide a subdomain proxy outside of code-server. For this we can probably just check if that variable is already set and if so avoid overriding.

To implement we need to check the proxy-domain flag and use that in the environment variable. It can be defined multiple times so maybe we just use the first one. So more or less I think it would be {{port}}.${args["proxy-domain"][0]}. If the flag is not set we just keep using the path-based proxy.

I also think we should go ahead and patch asExternalUri to use this same environment variable although we should use the other ticket for that (and a separate PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants