Skip to content

Set proxy URI to domain proxy when possible #6115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

code-asher
Copy link
Member

This will make the ports panel use it instead of the default path-based proxy.

Closes #5311

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #6115 (fa0bf67) into main (d477972) will increase coverage by 0.02%.
The diff coverage is 71.42%.

❗ Current head fa0bf67 differs from pull request most recent head 1d53523. Consider uploading reports for the commit 1d53523 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6115      +/-   ##
==========================================
+ Coverage   73.12%   73.15%   +0.02%     
==========================================
  Files          30       30              
  Lines        1704     1717      +13     
  Branches      374      380       +6     
==========================================
+ Hits         1246     1256      +10     
- Misses        383      385       +2     
- Partials       75       76       +1     
Impacted Files Coverage Δ
src/node/proxy.ts 83.33% <60.00%> (-16.67%) ⬇️
src/node/cli.ts 91.50% <100.00%> (+0.06%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78282a1...1d53523. Read the comment docs.

@code-asher code-asher force-pushed the set-domain-proxy-uri branch 5 times, most recently from 2a9bb51 to fa0bf67 Compare March 30, 2023 17:33
@code-asher code-asher marked this pull request as ready for review March 30, 2023 18:15
@code-asher code-asher requested a review from a team as a code owner March 30, 2023 18:15
@code-asher code-asher force-pushed the set-domain-proxy-uri branch 2 times, most recently from 5e5a243 to 9a2e2c9 Compare March 30, 2023 19:09
This will make the ports panel use it instead of the default path-based
proxy.
@code-asher code-asher force-pushed the set-domain-proxy-uri branch from 9a2e2c9 to 1d53523 Compare March 30, 2023 19:12
@code-asher code-asher merged commit c995988 into coder:main Mar 30, 2023
@code-asher code-asher deleted the set-domain-proxy-uri branch March 30, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: make VSCODE_PROXY_URI use the subdomain proxy when it is enabled
1 participant