Skip to content

Fix Proposed API #4480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jsjoeio opened this issue Nov 10, 2021 · 1 comment
Closed

Fix Proposed API #4480

jsjoeio opened this issue Nov 10, 2021 · 1 comment
Assignees
@code-asher
Labels
bug Something isn't working
Milestone
4.0.0 - pre-release

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Nov 10, 2021 •
edited by code-asher
Loading

Proposed API (either implement or always enable it and remove the flag)

Introduced in #4414

@code-asher may have more details.
@jsjoeio jsjoeio added the bug Something isn't working label Nov 10, 2021
@jsjoeio jsjoeio mentioned this issue Nov 10, 2021
Merged
46 tasks
@code-asher
Copy link
Member

code-asher commented Nov 10, 2021 •
edited
Loading

Per #4397 I think we should just always enable it and get rid of the flag (or make it a no-op).

@code-asher code-asher self-assigned this Nov 10, 2021
code-asher added a commit to coder/vscode that referenced this issue Nov 10, 2021
@code-asher
Enable proposed API by default
f12d59d 
Turns out we used to already do this and if you passed the flag you
would actually *disable* the global enable setting.  This is because we
were defaulting to an empty array which means to enable it globally.

Fixes coder/code-server#4397
Fixes coder/code-server#4480
@code-asher code-asher mentioned this issue Nov 10, 2021
Merged
code-asher added a commit to coder/vscode that referenced this issue Nov 10, 2021
@code-asher
Enable proposed API by default (#12)
a9ea411 
Turns out we used to already do this and if you passed the flag you
would actually *disable* the global enable setting.  This is because we
were defaulting to an empty array which means to enable it globally.

Fixes coder/code-server#4397
Fixes coder/code-server#4480
code-asher added a commit to code-asher/code-server that referenced this issue Nov 10, 2021
@code-asher
Update VS Code
71b1f9f 
Fixes coder#4397
Fixes coder#4480
Fixes coder#4482
Fixes coder#4484
Fixes coder#4489
@code-asher code-asher mentioned this issue Nov 10, 2021
Closed
@benz0li benz0li mentioned this issue Dec 16, 2021
Closed
ZauberNerd pushed a commit to ZauberNerd/vscode that referenced this issue Dec 23, 2021
@code-asher @ZauberNerd
Enable proposed API by default (microsoft#12)
4f14231 
Turns out we used to already do this and if you passed the flag you
would actually *disable* the global enable setting.  This is because we
were defaulting to an empty array which means to enable it globally.

Fixes coder/code-server#4397
Fixes coder/code-server#4480
ZauberNerd pushed a commit to ZauberNerd/vscode that referenced this issue Dec 23, 2021
@code-asher @ZauberNerd
Enable proposed API by default (microsoft#12)
d129d67 
Turns out we used to already do this and if you passed the flag you
would actually *disable* the global enable setting.  This is because we
were defaulting to an empty array which means to enable it globally.

Fixes coder/code-server#4397
Fixes coder/code-server#4480
ZauberNerd pushed a commit to ZauberNerd/vscode that referenced this issue Dec 23, 2021
@code-asher @ZauberNerd
Enable proposed API by default (microsoft#12)
230442a 
Turns out we used to already do this and if you passed the flag you
would actually *disable* the global enable setting.  This is because we
were defaulting to an empty array which means to enable it globally.

Fixes coder/code-server#4397
Fixes coder/code-server#4480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@code-asher code-asher

Labels
bug Something isn't working
Projects
None yet
Milestone
4.0.0 - pre-release
Development

Successfully merging a pull request may close this issue.

Update VS Code code-asher/code-server
2 participants
@jsjoeio @code-asher