Skip to content

Allow access to Proposed APIs from installed extensions by default #4397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
toddewilliams opened this issue Oct 25, 2021 · 5 comments
Closed
Labels
bug Something isn't working

Comments

@toddewilliams
Copy link
Contributor

VS Code restricts access to a series of important APIs under the heading of "proposed". A large number of these are APIs are stable and no longer experimental but are designed to never come out of "proposed" status for purely control and commercialization reasons.

Our extension, CodeTogether, requires access to these "proposed" APIs to provide services like exposing Terminals to CodeTogether participants. Microsoft whitelists their own extensions as part of the VS Code installation, of course.

It would be great if code-server could just disable limiting access to proposed APIs, removing the arbitrary limit on what extensions can access, that was drawn by Microsoft for competitive purposes. Additionally, it is simply not ideal to require a server-style VS Code deployment to require the entire server process to be restarted to allow access to these APIs.

If removing the proposed API restrictions can't be done (or can't be done quickly), then I'd like to request that you add genuitecllc.codetogether to the existing whitelist for code-server as this would also be greatly beneficial.

@toddewilliams toddewilliams added the feature New user visible feature label Oct 25, 2021
@TimWebb
Copy link

TimWebb commented Oct 25, 2021

The current available workaround is captured here:
https://coder.com/docs/code-server/latest/collaboration#installing-the-codetogether-extension

In short, the base way to enable is via restarting code-server with a command line (or config file), such as:
code-server --enable-proposed-api genuitecllc.codetogether
though this does require access to restart the server, and modifying potentially how CodeTogether is automatically started.

@code-asher code-asher added this to the Backlog milestone Oct 27, 2021
code-asher added a commit to coder/vscode that referenced this issue Nov 10, 2021
Turns out we used to already do this and if you passed the flag you
would actually *disable* the global enable setting.  This is because we
were defaulting to an empty array which means to enable it globally.

Fixes coder/code-server#4397
Fixes coder/code-server#4480
code-asher added a commit to code-asher/code-server that referenced this issue Nov 10, 2021
ZauberNerd pushed a commit to ZauberNerd/vscode that referenced this issue Dec 23, 2021
Turns out we used to already do this and if you passed the flag you
would actually *disable* the global enable setting.  This is because we
were defaulting to an empty array which means to enable it globally.

Fixes coder/code-server#4397
Fixes coder/code-server#4480
ZauberNerd pushed a commit to ZauberNerd/vscode that referenced this issue Dec 23, 2021
Turns out we used to already do this and if you passed the flag you
would actually *disable* the global enable setting.  This is because we
were defaulting to an empty array which means to enable it globally.

Fixes coder/code-server#4397
Fixes coder/code-server#4480
ZauberNerd pushed a commit to ZauberNerd/vscode that referenced this issue Dec 23, 2021
Turns out we used to already do this and if you passed the flag you
would actually *disable* the global enable setting.  This is because we
were defaulting to an empty array which means to enable it globally.

Fixes coder/code-server#4397
Fixes coder/code-server#4480
@dbush-clickup
Copy link

I'm seeing this issue with 2022.0.4 version (again? still?)

FWIW, my setup is VS Code on windows and developing in WSLg.

@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 13, 2022

@dbush-clickup do you mind posting basic repo steps?

@jsjoeio jsjoeio reopened this Apr 13, 2022
@dbush-clickup
Copy link

@dbush-clickup do you mind posting basic repo steps?

  1. Install CodeTogether on VS Code Windows.
  2. When prompted for "CodeTogether requires access to VS Code Proposed APIs..." click "Enable"
  3. Shut down VS Code
  4. Reload VS Code
  5. goto 2)

I don't even have to have a project loaded so does not seem specific to WSL at all.

@jsjoeio jsjoeio added bug Something isn't working needs-investigation This issue needs to be further investigated and removed feature New user visible feature labels Apr 14, 2022
@code-asher code-asher removed the needs-investigation This issue needs to be further investigated label Jul 11, 2024
@code-asher
Copy link
Member

Closing as I believe we always enable the proposed API now, but if there is a bug with this let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants