Skip to content

Add back support for non-encoded syntax for folder and workspace query params #4484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jsjoeio opened this issue Nov 10, 2021 · 2 comments
Closed

Add back support for non-encoded syntax for folder and workspace query params #4484

jsjoeio opened this issue Nov 10, 2021 · 2 comments
Assignees
@code-asher
Labels
bug Something isn't working
Milestone
4.0.0 - pre-release

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Nov 10, 2021 •
edited by code-asher
Loading

Introduced in #4414

@code-asher may have more details.
@jsjoeio jsjoeio added the bug Something isn't working label Nov 10, 2021
@jsjoeio jsjoeio mentioned this issue Nov 10, 2021
Merged
46 tasks
@code-asher
Copy link
Member

To test:

  1. Try going to localhost:8080/?folder=/path/to/my/directory
  2. Observe the directory does not open

We used to patch it so you could use this paths like these but currently you have to do some encoding by hand, for example vscode-remote%3A%2F%2Fpath%2Fto%2Fmy%2Fdirectory which feels unreasonable.

@code-asher code-asher self-assigned this Nov 10, 2021
@code-asher code-asher mentioned this issue Nov 10, 2021
Merged
code-asher added a commit to code-asher/code-server that referenced this issue Nov 10, 2021
@code-asher
Update VS Code
71b1f9f 
Fixes coder#4397
Fixes coder#4480
Fixes coder#4482
Fixes coder#4484
Fixes coder#4489
@code-asher code-asher mentioned this issue Nov 10, 2021
Closed
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Nov 18, 2021

@code-asher can we close this via coder/vscode#15?

ZauberNerd pushed a commit to ZauberNerd/vscode that referenced this issue Dec 23, 2021
@code-asher @ZauberNerd
Add back support for unencoded folder/workspace query params (microso…
13c1546 
…ft#15)

* Add back support for unencoded folder/workspace query params

Fixes coder/code-server#4484.

* Standardize on @author for marking our changes
ZauberNerd pushed a commit to ZauberNerd/vscode that referenced this issue Dec 23, 2021
@code-asher @ZauberNerd
Add back support for unencoded folder/workspace query params (microso…
06dabdb 
…ft#15)

* Add back support for unencoded folder/workspace query params

Fixes coder/code-server#4484.

* Standardize on @author for marking our changes
ZauberNerd pushed a commit to ZauberNerd/vscode that referenced this issue Dec 23, 2021
@code-asher @ZauberNerd
Add back support for unencoded folder/workspace query params (microso…
a6180cb 
…ft#15)

* Add back support for unencoded folder/workspace query params

Fixes coder/code-server#4484.

* Standardize on @author for marking our changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@code-asher code-asher

Labels
bug Something isn't working
Projects
None yet
Milestone
4.0.0 - pre-release
Development

Successfully merging a pull request may close this issue.

Update VS Code code-asher/code-server
2 participants
@jsjoeio @code-asher