Shiny app forecaster options cleanup #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dsweber2 Does this fix your plotting problem? I wasn't able to reproduce, but I was having another issue with the shiny app due to ensemble names no longer being unique. Your issue seemed similar -- 4 names being provided seems like it would be related to us generating the 4 aheads separately. Testing shiny apps is hard in general. There are some snapshot-based tests to check that behavior is stable. We're probably not there yet, but unit tests and assertions/checks in-code would be useful. The app doesn't use so many functions, so we'd need to refactor it to isolate testable code. |
dsweber2
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forecaster options must be unique or shiny fails in weird ways. Also check that to-be-plotted forecasters are empty even if not length-0. Sometimes we end up with a non-informative list
c("")that doesn't trigger the empty df to be returned.