Skip to content

Commit 0bd0b55

Browse files
authored
Merge pull request #63 from cmu-delphi/ndefries/unique-forecaster-options
Shiny app forecaster options cleanup
2 parents 26cbf91 + 833b4b7 commit 0bd0b55

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

app.R

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,11 @@ shinyApp(
136136
server = function(input, output, session) {
137137
filtered_scorecards_reactive <- reactive({
138138
agg_forecasters <- unique(c(input$selected_forecasters, input$baseline))
139-
if (length(agg_forecasters) == 0) { return(data.frame()) }
139+
if (length(agg_forecasters) == 0 ||
140+
all(agg_forecasters == "" | is.null(agg_forecasters) | is.na(agg_forecasters))
141+
) {
142+
return(data.frame())
143+
}
140144

141145
processed_evaluations_internal <- lapply(agg_forecasters, function(forecaster) {
142146
load_forecast_data(forecaster) %>>%

run.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,15 +119,15 @@ if (use_shiny == "y") {
119119
)
120120

121121
# Add ensembles
122-
ensemble_options <- tar_read(ensemble_forecasters)[["parent_id"]]
122+
ensemble_options <- unique(tar_read(ensemble_forecasters)[["parent_id"]])
123123
ensemble_options <- setNames(
124124
# File names
125125
paste0("ensemble_score_", ensemble_options),
126126
# Display names
127127
paste0("ensemble.", ensemble_options)
128128
)
129129

130-
external_options <- tar_read(external_names)
130+
external_options <- unique(tar_read(external_names))
131131
EXTERNAL_PREFIX <- "[external] "
132132
if (!is.null(external_options) && length(external_options) > 0) {
133133
external_options <- setNames(

0 commit comments

Comments
 (0)