-
Notifications
You must be signed in to change notification settings - Fork 0
ensemble models #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ensemble models #51
Conversation
e01d3f3
to
c4abc0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
initial review, will do another pass after merge
@nmdefries I'm having some difficulties getting the ensembles to plot in the shiny dashboard; hypothetically it should be just the same data format as the other forecasters, but it's throwing errors. Looking at e.g.
|
…ions Shiny app forecaster options cleanup
@dshemetov with Nat's fix of the dashboard, I think this is finally ready for final review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, we probably need to get this PR in and iterate instead of polishing it for more weeks, but I made some comments here and there.
If you want to merge and get an actual largescale run going on mentat over the weekend that would be awesome. Kinda wish there were a good mechanism for migrating review items to issues, but there's this: #70. |
An issue with a linkback works! |
closes #37, #4, and now #21
A PR to add ensembles. Initially this is just adding one that averages the quantiles of the forecasts handed to it (using a user-specified function, which is currently targeting median and mean), I'm currently working on adding in the proper targets and naming scheme, which is why this is a draft