Skip to content

133 fix residuals #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 15, 2022
Merged

133 fix residuals #134

merged 4 commits into from
Sep 15, 2022

Conversation

dajmcdon
Copy link
Contributor

Closes #133.

The basic issue is that the test data must be complete (or at least have enough non-NAs to do something). In the sliding vignette, many locations are missing recent percent_cli so the predictions got a bit odd.

Changes:

  • Update to get_test_data() to allow for NA fill and print messages if there's insufficient data for the fill.
  • Move epiprocess to Depends, since this package is fundamentally linked to it.
  • Changed default residual_quantile values (the old ones were strange).

@dajmcdon dajmcdon requested a review from rachlobay September 14, 2022 22:16
Copy link
Contributor

@rachlobay rachlobay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After fixing that one test & adding a little more description to n_recent in get_test_data, looks good to merge (after all checks pass).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Residuals from non-lm engines
2 participants