Skip to content

Residuals from non-lm engines #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dajmcdon opened this issue Sep 12, 2022 · 1 comment · Fixed by #134
Closed

Residuals from non-lm engines #133

dajmcdon opened this issue Sep 12, 2022 · 1 comment · Fixed by #134
Assignees

Comments

@dajmcdon
Copy link
Contributor

Looking at the sliding.Rmd vignette, the random forest prediction intervals are very narrow. Is there a bug somewhere in the residual_quantiles()?

@dajmcdon
Copy link
Contributor Author

dajmcdon commented Sep 14, 2022

Update: seemingly two bugs.

  1. There's a bug in the residual calculation when residuals.fit_engine() is unavailable (it tries to use the test data).
  2. We need to impute missing values. For now, I'm adding a step_impute_locf() function (though one could use recipes::step_impute_roll() if desired.

@dajmcdon dajmcdon self-assigned this Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant