Skip to content

A preprocessing step that fills NAs #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dajmcdon opened this issue Oct 28, 2022 · 1 comment
Closed

A preprocessing step that fills NAs #146

dajmcdon opened this issue Oct 28, 2022 · 1 comment
Assignees
@rachlobay
Labels
P0 do this immediately

Comments

@dajmcdon
Copy link
Contributor

dajmcdon commented Oct 28, 2022 •
edited
Loading

Sometimes we have NAs at test time. These need to be filled somehow. This should be added as an option to get_test_data().

This addresses the issue in the sliding vignette.

Note that one could potentially do imputation at train time using something like recipes::step_impute_roll().
@dajmcdon dajmcdon added the P0 do this immediately label Oct 28, 2022
@dajmcdon
Copy link
Contributor Author

Closed by #134.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rachlobay rachlobay

Labels
P0 do this immediately
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dajmcdon @rachlobay