Doctor's visits package #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
capnrefsmmat
commented
Jun 12, 2020
capnrefsmmat
commented
- Review recent history in covid-19 repo and port over changes
- Make tests for those
- Have Maria review
- Retire the covid-19 version of this code
added 2 commits
May 28, 2020 12:11
Needs some more unit tests, but otherwise ready to go.
1 task
Refactor doctor visits to use geo utils package
Fix (?) Doctor Visits Megacounty Bug
Remove unused DV code after geo refactor
Keep thresholded counties for future calculations
|
Hi @capnrefsmmat -- we are looking at this again because would like to have all the active indicators in the main branch. Is there anything outstanding here that you want to tackle before merging? |
|
Verdict from Slack was: ready to merge |
|
Double checked against #638; this PR uses the exact same dv code as the currently deployed version. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.