Skip to content

Remove unused DV code after geo refactor #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2020
Merged

Remove unused DV code after geo refactor #556

merged 1 commit into from
Nov 30, 2020

Conversation

chinandrew
Copy link
Contributor

@chinandrew chinandrew commented Nov 19, 2020 •
edited by krivard
Loading

Description

There was some left over code that called static mapping files which don't get used now that the refactor is done.

Changelog

Itemize code/test/documentation changes and files added/removed.

  • Remove code that reads static files
  • Remove static files

Fixes

@chinandrew chinandrew changed the base branch from main to dv-package November 19, 2020 18:32
mariajahja
mariajahja approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@mariajahja mariajahja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@krivard krivard merged commit 766bba5 into dv-package Nov 30, 2020
@krivard krivard deleted the unused-dv-code branch November 30, 2020 22:17
@chinandrew chinandrew mentioned this pull request Dec 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariajahja mariajahja mariajahja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chinandrew @mariajahja @krivard