Skip to content

EMR hospitalization indicator #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 24, 2020
Merged

Conversation

capnrefsmmat
Copy link
Contributor

  • needs tests

@mariajahja mariajahja linked an issue Jun 13, 2020 that may be closed by this pull request
@mariajahja
Copy link
Member

@capnrefsmmat I've added a few unit tests, with the exception of the geo_map.py and the largest update_sensor::update_sensor() function (not sure the latter is good on run time, though I can spend some more time making a smaller testing dataset if needed). Let me know.

@capnrefsmmat
Copy link
Contributor Author

@jsharpna Both this PR and #76 have synthetic data, so you should be able to start with either. I think this PR just needs review, while #76 will require us to check the changes that Maria has recently made in the covid-19 repository and port them to the new code.

Beyond those tasks, the remaining thing I wanted to do was to combine code. This repository contains _delphi_utils_python/, a Python package for common features and functions; I wanted to extract out the common features of geo_map.py to that package, so these two indicators do not have redundant code and redundant geographical data.

(The geographical stuff handles aggregation from ZIP codes to counties to metropolitan statistical areas (MSAs), states, and hospital referral regions (HRRs); it involves a bunch of mapping files we have to keep up to date and other gross stuff, so it's best that all the code shares it.)

Perhaps you could start spelunking through whichever of these two branches seems most approachable, then let us know what you think you can do and if you'd like an orientation Zoom session or anything?

@mariajahja mariajahja changed the base branch from master to hosp-admit-stable June 21, 2020 13:55
@mariajahja mariajahja merged commit 0592d17 into hosp-admit-stable Jun 24, 2020
@krivard krivard deleted the emr-hosp-package branch September 1, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants