Skip to content

Add support to clear custom dimensions #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 16, 2022
Merged

Conversation

markkuhn
Copy link
Contributor

Issue #, if available: #34

Related:

Description of changes:

  • Added a resetDimensions() method for clearing custom dimensions
  • Added a field to MetricsLogger to configure flush() to preserve/not preserve custom dimensions
  • adjusted README to reflect the correct behaviour of flush(), resetDimensions and setDimensions()

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Mark Kuhn added 3 commits September 7, 2022 10:50
move isascii to separate method
rm unit from validation
change input params to readonly
@markkuhn markkuhn merged commit 4444802 into awslabs:main Sep 16, 2022
@markkuhn markkuhn deleted the fix-#34 branch September 16, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support resetting custom dimensions and related enhancements
3 participants