Skip to content

Add support to clear custom dimensions #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 16, 2022
Merged

Add support to clear custom dimensions #136

merged 5 commits into from
Sep 16, 2022

Conversation

markkuhn
Copy link
Contributor

@markkuhn markkuhn commented Sep 13, 2022

Issue #, if available: #132

Related:

Description of changes:

  • Added a resetDimensions() method for clearing custom dimensions
  • Added a field to MetricsLogger to configure flush() to preserve/not preserve custom dimensions
  • adjusted README to reflect the correct behaviour of flush(), resetDimensions and setDimensions()

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@markkuhn markkuhn self-assigned this Sep 13, 2022
@markkuhn markkuhn added the enhancement New feature or request label Sep 13, 2022
@markkuhn markkuhn linked an issue Sep 13, 2022 that may be closed by this pull request
@markkuhn markkuhn requested review from amazon-ankalini and removed request for giancarlokc September 13, 2022 00:38
@markkuhn markkuhn changed the title add support to clear custom dimensions Add support to clear custom dimensions Sep 13, 2022
@markkuhn markkuhn merged commit 8382f5e into awslabs:master Sep 16, 2022
@markkuhn markkuhn deleted the fix-#132 branch September 16, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support resetting custom dimensions and related enhancements
3 participants