Skip to content

Support resetting custom dimensions and related enhancements #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Stephen-Bao opened this issue Aug 19, 2022 · 0 comments · Fixed by #38
Closed

Support resetting custom dimensions and related enhancements #34

Stephen-Bao opened this issue Aug 19, 2022 · 0 comments · Fixed by #38
Assignees
@markkuhn
Labels
enhancement New feature or request

Comments

@Stephen-Bao
Copy link

Stephen-Bao commented Aug 19, 2022 •
edited
Loading

Related issue:

This is the equivalent enhancements related to resetting custom dimensions in the Dotnet library. Similar APIs and features should be implemented in all libraries for consistency. Specifially, the enhancements include:

  • Provide a ResetDimensions(bool useDefault) API for resetting dimensions
  • Provide a feature flag to control whether Flush() should preserve custom dimensions after each execution
  • Provide a setDimensions(bool useDefault, params DimensionSet[] dimensionSets) API to control the behavior of default dimensions while setting new dimensions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markkuhn markkuhn

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support to clear custom dimensions markkuhn/aws-embedded-metrics-dotnet
2 participants
@markkuhn @Stephen-Bao