fix: removing kwargs as this is breaking predictor_cls param for mode… #4816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErnevSharma
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
JGuinegagne
reviewed
Aug 2, 2024
src/sagemaker/model.py
Outdated
| @@ -1696,8 +1696,7 @@ def deploy( | |||
| instance_type=instance_type, | |||
| accelerator_type=accelerator_type, | |||
| tags=tags, | |||
| serverless_inference_config=serverless_inference_config, | |||
| **kwargs, | |||
| serverless_inference_config=serverless_inference_config | |||
There was a problem hiding this comment.
oof, this looks like a backward incompatible change, are you sure we can simply do that?
We have to explicitly list the arguments that are eligible to be passed here.
ErnevSharma
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
ErnevSharma
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
JGuinegagne
previously approved these changes
Aug 2, 2024
ErnevSharma
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
evakravi
reviewed
Aug 5, 2024
| @@ -1697,7 +1700,8 @@ def deploy( | |||
| accelerator_type=accelerator_type, | |||
| tags=tags, | |||
| serverless_inference_config=serverless_inference_config, | |||
| **kwargs, | |||
There was a problem hiding this comment.
optional: maybe log any kwargs that are being ignored?
ErnevSharma
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
ErnevSharma
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
evakravi
reviewed
Aug 5, 2024
| @@ -771,7 +771,7 @@ def test_jumpstart_model_kwargs_match_parent_class(self): | |||
| and reach out to JumpStart team.""" | |||
|
|
|||
| init_args_to_skip: Set[str] = set(["model_reference_arn"]) | |||
| deploy_args_to_skip: Set[str] = set(["kwargs"]) | |||
| deploy_args_to_skip: Set[str] = set(["kwargs", "model_reference_arn"]) | |||
There was a problem hiding this comment.
why don't we accept this argument for JumpStartModel.deploy?
ErnevSharma
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
ErnevSharma
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
evakravi
approved these changes
Aug 6, 2024
sage-maker
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…l deploy
Issue #, if available:
Description of changes:
predictor_clsis not expected as an argument to_create_sagemaker_model.Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.