Skip to content

fix: removing kwargs as this is breaking predictor_cls param for mode… #4816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 6, 2024
Merged

fix: removing kwargs as this is breaking predictor_cls param for mode… #4816

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
109c161
fix: removing kwargs as this is breaking predictor_cls param for mode…
Aug 2, 2024
37a4038
Merge branch 'master' into fix-remove-kwargs
ErnevSharma Aug 2, 2024
63dab51
fix: include all known fields directly in create_sagemaker_model func…
Aug 2, 2024
3764325
Merge branch 'master' into fix-remove-kwargs
ErnevSharma Aug 5, 2024
5b3a956
chore: fixing model deploy tests to incorporate new params
Aug 5, 2024
4d111f9
chore: fix formatting
Aug 5, 2024
5dd0b9f
Merge branch 'master' into fix-remove-kwargs
ErnevSharma Aug 5, 2024
29be8aa
Merge branch 'master' into fix-remove-kwargs
ErnevSharma Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/sagemaker/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1696,8 +1696,7 @@ def deploy(
instance_type=instance_type,
accelerator_type=accelerator_type,
tags=tags,
serverless_inference_config=serverless_inference_config,
**kwargs,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional: maybe log any kwargs that are being ignored?

serverless_inference_config=serverless_inference_config
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof, this looks like a backward incompatible change, are you sure we can simply do that?

We have to explicitly list the arguments that are eligible to be passed here.

)
serverless_inference_config_dict = (
serverless_inference_config._to_request_dict() if is_serverless else None
Expand Down
Loading