-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: removing kwargs as this is breaking predictor_cls param for mode… #4816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
109c161
fix: removing kwargs as this is breaking predictor_cls param for mode…
37a4038
Merge branch 'master' into fix-remove-kwargs
ErnevSharma 63dab51
fix: include all known fields directly in create_sagemaker_model func…
3764325
Merge branch 'master' into fix-remove-kwargs
ErnevSharma 5b3a956
chore: fixing model deploy tests to incorporate new params
4d111f9
chore: fix formatting
5dd0b9f
Merge branch 'master' into fix-remove-kwargs
ErnevSharma 29be8aa
Merge branch 'master' into fix-remove-kwargs
ErnevSharma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optional: maybe log any kwargs that are being ignored?