Skip to content

Do not run tensorflow integ tests when running python 3. #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 1, 2018

Conversation

nadiaya
Copy link
Contributor

@nadiaya nadiaya commented Aug 31, 2018

Do not run tensorflow integ tests when running python 3 since we do not have python 3 image for tensorflow.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

yangaws
yangaws previously approved these changes Aug 31, 2018
Copy link
Contributor

@yangaws yangaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yangaws
yangaws previously approved these changes Aug 31, 2018
@nadiaya nadiaya merged commit 33c7e43 into aws:master Sep 1, 2018
@nadiaya nadiaya deleted the run-py2 branch September 1, 2018 04:09
pdasamzn pushed a commit to pdasamzn/sagemaker-python-sdk that referenced this pull request Nov 1, 2018
* Do not run tensorflow integ tests when running python 3 since we do not have python 3 image for tensorflow.

* Correct docs to reflect that upload_data would create only default bucket. (aws#373)

* Skip TF when running local mode and tuner integ tests in python3.
apacker pushed a commit to apacker/sagemaker-python-sdk that referenced this pull request Nov 15, 2018
Fixed: typos about containers in linear forecast notebook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants