Skip to content

Commit 6a945b4

Browse files
committed
Skip TF when running local mode and tuner integ tests in python3.
1 parent ba8e9b8 commit 6a945b4

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

tests/integ/test_local_mode.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
from sagemaker.mxnet import MXNet, MXNetModel
2525
from sagemaker.tensorflow import TensorFlow
2626
from sagemaker.fw_utils import tar_and_upload_dir
27-
from tests.integ import DATA_DIR
27+
from tests.integ import DATA_DIR, PYTHON_VERSION
2828
from tests.integ.timeout import timeout
2929

3030
DATA_PATH = os.path.join(DATA_DIR, 'iris', 'data')
@@ -75,6 +75,7 @@ def mxnet_model(sagemaker_local_session):
7575
return model
7676

7777

78+
@pytest.mark.skipif(PYTHON_VERSION != 'py2', reason="TensorFlow image supports only python 2.")
7879
def test_tf_local_mode(tf_full_version, sagemaker_local_session):
7980
local_mode_lock_fd = open(LOCK_PATH, 'w')
8081
local_mode_lock = local_mode_lock_fd.fileno()
@@ -120,6 +121,7 @@ def test_tf_local_mode(tf_full_version, sagemaker_local_session):
120121
fcntl.lockf(local_mode_lock, fcntl.LOCK_UN)
121122

122123

124+
@pytest.mark.skipif(PYTHON_VERSION != 'py2', reason="TensorFlow image supports only python 2.")
123125
def test_tf_distributed_local_mode(sagemaker_local_session):
124126
local_mode_lock_fd = open(LOCK_PATH, 'w')
125127
local_mode_lock = local_mode_lock_fd.fileno()
@@ -164,6 +166,7 @@ def test_tf_distributed_local_mode(sagemaker_local_session):
164166
fcntl.lockf(local_mode_lock, fcntl.LOCK_UN)
165167

166168

169+
@pytest.mark.skipif(PYTHON_VERSION != 'py2', reason="TensorFlow image supports only python 2.")
167170
def test_tf_local_data(sagemaker_local_session):
168171
local_mode_lock_fd = open(LOCK_PATH, 'w')
169172
local_mode_lock = local_mode_lock_fd.fileno()
@@ -206,6 +209,7 @@ def test_tf_local_data(sagemaker_local_session):
206209
fcntl.lockf(local_mode_lock, fcntl.LOCK_UN)
207210

208211

212+
@pytest.mark.skipif(PYTHON_VERSION != 'py2', reason="TensorFlow image supports only python 2.")
209213
def test_tf_local_data_local_script():
210214
local_mode_lock_fd = open(LOCK_PATH, 'w')
211215
local_mode_lock = local_mode_lock_fd.fileno()

tests/integ/test_tuner.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
from sagemaker.pytorch import PyTorch
3333
from sagemaker.tensorflow import TensorFlow
3434
from sagemaker.tuner import IntegerParameter, ContinuousParameter, CategoricalParameter, HyperparameterTuner
35-
from tests.integ import DATA_DIR, TUNING_DEFAULT_TIMEOUT_MINUTES
35+
from tests.integ import DATA_DIR, PYTHON_VERSION, TUNING_DEFAULT_TIMEOUT_MINUTES
3636
from tests.integ.record_set import prepare_record_set_from_local_files
3737
from tests.integ.timeout import timeout, timeout_and_delete_endpoint_by_name
3838

@@ -218,6 +218,7 @@ def test_tuning_mxnet(sagemaker_session):
218218

219219

220220
@pytest.mark.continuous_testing
221+
@pytest.mark.skipif(PYTHON_VERSION != 'py2', reason="TensorFlow image supports only python 2.")
221222
def test_tuning_tf(sagemaker_session):
222223
with timeout(minutes=TUNING_DEFAULT_TIMEOUT_MINUTES):
223224
script_path = os.path.join(DATA_DIR, 'iris', 'iris-dnn-classifier.py')

0 commit comments

Comments
 (0)