Skip to content

Correct docs to reflect that upload_data would create only default bucket. #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 31, 2018

Conversation

nadiaya
Copy link
Contributor

@nadiaya nadiaya commented Aug 31, 2018

Correct docs to reflect that upload_data would create only default bucket.

Issue #371

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nadiaya nadiaya requested a review from iquintero August 31, 2018 18:45
@codecov-io
Copy link

Codecov Report

Merging #373 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #373   +/-   ##
======================================
  Coverage    92.9%   92.9%           
======================================
  Files          51      51           
  Lines        3568    3568           
======================================
  Hits         3315    3315           
  Misses        253     253
Impacted Files Coverage Δ
src/sagemaker/session.py 88.86% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4add5fc...89ad455. Read the comment docs.

@nadiaya nadiaya merged commit c872c10 into aws:master Aug 31, 2018
@nadiaya nadiaya deleted the upload-doc branch August 31, 2018 21:41
nadiaya added a commit to nadiaya/sagemaker-python-sdk that referenced this pull request Aug 31, 2018
nadiaya added a commit to nadiaya/sagemaker-python-sdk that referenced this pull request Aug 31, 2018
nadiaya added a commit that referenced this pull request Sep 1, 2018
* Do not run tensorflow integ tests when running python 3 since we do not have python 3 image for tensorflow.

* Correct docs to reflect that upload_data would create only default bucket. (#373)

* Skip TF when running local mode and tuner integ tests in python3.
pdasamzn pushed a commit to pdasamzn/sagemaker-python-sdk that referenced this pull request Nov 1, 2018
pdasamzn pushed a commit to pdasamzn/sagemaker-python-sdk that referenced this pull request Nov 1, 2018
* Do not run tensorflow integ tests when running python 3 since we do not have python 3 image for tensorflow.

* Correct docs to reflect that upload_data would create only default bucket. (aws#373)

* Skip TF when running local mode and tuner integ tests in python3.
apacker pushed a commit to apacker/sagemaker-python-sdk that referenced this pull request Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants