feature: support specifying env-vars when creating model from model package #3581

saumitravikram · 2023-01-10T11:07:20Z

Issue #, if available: #3301

Description of changes: Changes made to enable back specifying of environment variable when creating model from model package. Previously service use to throw exception Environment variable map cannot be specified both at Model Package and Model thus above change was made in python sdk to exclude specifying environment variable. Now service is supporting the same and we are including back the change.

Testing done:
Unit testing
tox -e py38 tests/unit/

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…ackage

sagemaker-bot · 2023-01-10T11:13:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 7a4e4ce
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

tests/unit/sagemaker/model/test_model_package.py

rahven14

Approval from SRS team

sagemaker-bot · 2023-01-10T12:19:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: b04601d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-10T12:21:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: b04601d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-10T12:22:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: b04601d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-10T12:23:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: b04601d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-10T12:39:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: b04601d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

knikure

/bot run slow-tests

sagemaker-bot · 2023-01-17T19:18:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: b04601d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-17T19:31:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: b04601d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

saumitravikram · 2023-01-17T20:03:49Z

/bot run notebook-tests

sagemaker-bot · 2023-01-17T22:41:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: b04601d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-01-18T03:44:18Z

Codecov Report

Merging #3581 (b36d27f) into master (1fa2377) will decrease coverage by 0.38%.
The diff coverage is 87.78%.

@@            Coverage Diff             @@
##           master    #3581      +/-   ##
==========================================
- Coverage   89.17%   88.80%   -0.38%     
==========================================
  Files         204      227      +23     
  Lines       18979    22143    +3164     
==========================================
+ Hits        16924    19663    +2739     
- Misses       2055     2480     +425

Impacted Files	Coverage Δ
src/sagemaker/dataset_definition/inputs.py	`100.00% <ø> (ø)`
src/sagemaker/huggingface/model.py	`89.87% <ø> (ø)`
src/sagemaker/lineage/_utils.py	`100.00% <ø> (+12.50%)`	⬆️
src/sagemaker/pipeline.py	`85.33% <ø> (ø)`
src/sagemaker/pytorch/training_compiler/config.py	`84.61% <ø> (ø)`
src/sagemaker/rl/estimator.py	`93.05% <ø> (ø)`
src/sagemaker/session.py	`73.95% <ø> (+2.29%)`	⬆️
src/sagemaker/sklearn/estimator.py	`93.93% <ø> (-6.07%)`	⬇️
src/sagemaker/sklearn/model.py	`92.98% <ø> (-1.76%)`	⬇️
src/sagemaker/spark/processing.py	`98.70% <ø> (+0.08%)`	⬆️
... and 96 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagemaker-bot · 2023-01-18T04:22:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: b8da3a7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-18T04:23:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: b8da3a7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-18T04:29:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: b8da3a7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-18T04:37:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: b8da3a7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-18T04:47:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: b8da3a7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-18T19:05:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: b8da3a7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-18T20:55:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: b8da3a7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-19T05:40:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: b36d27f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-19T05:40:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: b36d27f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-19T05:50:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: b36d27f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-19T06:04:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: b36d27f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-19T07:50:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: b36d27f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-19T19:19:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: b36d27f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…ackage (aws#3581) * feature: support specifying env-vars when creating model from model package * Updating unit test Co-authored-by: Saumitra Vikram <[email protected]>

feature: support specifying env-vars when creating model from model p…

7a4e4ce

…ackage

saumitravikram requested a review from a team as a code owner January 10, 2023 11:07

saumitravikram requested review from trajanikant and removed request for a team January 10, 2023 11:07

saumitravikram requested review from a team and removed request for trajanikant January 10, 2023 11:21

rahven14 reviewed Jan 10, 2023

View reviewed changes

tests/unit/sagemaker/model/test_model_package.py Outdated Show resolved Hide resolved

rahven14 reviewed Jan 10, 2023

View reviewed changes

tests/unit/sagemaker/model/test_model_package.py Outdated Show resolved Hide resolved

Updating unit test

b04601d

rahven14 approved these changes Jan 10, 2023

View reviewed changes

knikure reviewed Jan 17, 2023

View reviewed changes

knikure self-assigned this Jan 17, 2023

knikure approved these changes Jan 18, 2023

View reviewed changes

Merge branch 'master' into include-env-vars

b8da3a7

Merge branch 'master' into include-env-vars

b36d27f

knikure merged commit 420f3a9 into aws:master Jan 20, 2023

feature: support specifying env-vars when creating model from model package #3581

feature: support specifying env-vars when creating model from model package #3581

Uh oh!

Conversation

saumitravikram commented Jan 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Jan 10, 2023

AWS CodeBuild CI Report

Uh oh!

Uh oh!

Uh oh!

rahven14 left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Jan 10, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 10, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 10, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 10, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 10, 2023

AWS CodeBuild CI Report

Uh oh!

knikure left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Jan 17, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 17, 2023

AWS CodeBuild CI Report

Uh oh!

saumitravikram commented Jan 17, 2023 • edited by knikure Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sagemaker-bot commented Jan 17, 2023

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Jan 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Jan 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 19, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 19, 2023

AWS CodeBuild CI Report

Uh oh!

saumitravikram commented Jan 10, 2023 •

edited

Loading

knikure left a comment •

edited

Loading

saumitravikram commented Jan 17, 2023 •

edited by knikure

Loading

codecov-commenter commented Jan 18, 2023 •

edited

Loading