Skip to content

Commit 420f3a9

Browse files
saumitravikramSaumitra Vikram
and
Saumitra Vikram
authored
feature: Support specifying env-vars when creating model from model package (#3581)
* feature: support specifying env-vars when creating model from model package * Updating unit test Co-authored-by: Saumitra Vikram <[email protected]>
1 parent 2b7ae62 commit 420f3a9

File tree

2 files changed

+29
-0
lines changed

2 files changed

+29
-0
lines changed

src/sagemaker/model.py

+3
Original file line numberDiff line numberDiff line change
@@ -1620,6 +1620,9 @@ def _create_sagemaker_model(self, *args, **kwargs): # pylint: disable=unused-ar
16201620

16211621
container_def = {"ModelPackageName": model_package_name}
16221622

1623+
if self.env != {}:
1624+
container_def["Environment"] = self.env
1625+
16231626
self._ensure_base_name_if_needed(model_package_name.split("/")[-1])
16241627
self._set_model_name_if_needed()
16251628

tests/unit/sagemaker/model/test_model_package.py

+26
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,32 @@ def test_create_sagemaker_model_uses_model_name(name_from_base, sagemaker_sessio
115115
)
116116

117117

118+
def test_create_sagemaker_model_include_environment_variable(sagemaker_session):
119+
model_name = "my-model"
120+
model_package_name = "my-model-package"
121+
env_key = "env_key"
122+
env_value = "env_value"
123+
environment = {env_key: env_value}
124+
125+
model_package = ModelPackage(
126+
role="role",
127+
name=model_name,
128+
model_package_arn=model_package_name,
129+
env=environment,
130+
sagemaker_session=sagemaker_session,
131+
)
132+
133+
model_package._create_sagemaker_model()
134+
135+
sagemaker_session.create_model.assert_called_with(
136+
model_name,
137+
"role",
138+
{"ModelPackageName": model_package_name, "Environment": environment},
139+
vpc_config=None,
140+
enable_network_isolation=False,
141+
)
142+
143+
118144
@patch("sagemaker.utils.name_from_base")
119145
def test_create_sagemaker_model_generates_model_name(name_from_base, sagemaker_session):
120146
model_package_name = "my-model-package"

0 commit comments

Comments
 (0)