Skip to content

feature: support specifying env-vars when creating model from model package #3581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 20, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/sagemaker/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -1620,6 +1620,9 @@ def _create_sagemaker_model(self, *args, **kwargs): # pylint: disable=unused-ar

container_def = {"ModelPackageName": model_package_name}

if self.env != {}:
container_def["Environment"] = self.env

self._ensure_base_name_if_needed(model_package_name.split("/")[-1])
self._set_model_name_if_needed()

Expand Down
26 changes: 26 additions & 0 deletions tests/unit/sagemaker/model/test_model_package.py
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,32 @@ def test_create_sagemaker_model_uses_model_name(name_from_base, sagemaker_sessio
)


def test_create_sagemaker_model_include_environment_variable(sagemaker_session):
model_name = "my-model"
model_package_name = "my-model-package"
env_key = "env_key"
env_value = "env_value"
environment = {env_key: env_value}

model_package = ModelPackage(
role="role",
name=model_name,
model_package_arn=model_package_name,
env=environment,
sagemaker_session=sagemaker_session,
)

model_package._create_sagemaker_model()

sagemaker_session.create_model.assert_called_with(
model_name,
"role",
{"ModelPackageName": model_package_name, "Environment": environment},
vpc_config=None,
enable_network_isolation=False,
)


@patch("sagemaker.utils.name_from_base")
def test_create_sagemaker_model_generates_model_name(name_from_base, sagemaker_session):
model_package_name = "my-model-package"
Expand Down