Doc update for TableFormatEnum #3542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Eric Zou <[email protected]>
Co-authored-by: Eric Zou <[email protected]>
) * Bug fixed - as_of, event_range, join, default behavior and duplicates and tests Bugs: 1. as_of was not working properly on deleted events 2. Same event_time_range 3. Join was not working when including feature names 4. Default sql was returning only most recent, whereas it should all excluding duplicates 5. Include duplicates was not return all non-deleted data 6. instanceof(dataframe) case was also applied to non-df cases while join 7. Include column was returning unnecessary columns. * Fix on pylint error * Fix on include_duplicated_records for panda data frames * Fix format issue for black * Bug fixed related to line break * Bug fix related to dataframe and inclde_deleted_record and include_duplicated_record * Addressed comments and code refactored * changed to_csv to to_csv_file and added error messages for query limit and recent record limit * Revert a change which was not intended * Resolved the leak of feature group deletion in integration test
mizanfiu
requested review from
mufaddal-rohawala
and removed request for
a team
claytonparnell
approved these changes
Dec 15, 2022
AWS-pratab
approved these changes
Dec 15, 2022
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
claytonparnell
pushed a commit
to claytonparnell/sagemaker-python-sdk
that referenced
this pull request
Dec 16, 2022
* Updated doc for table format Enum
mufaddal-rohawala
pushed a commit
to mufaddal-rohawala/sagemaker-python-sdk
that referenced
this pull request
Dec 19, 2022
* Updated doc for table format Enum
mufaddal-rohawala
pushed a commit
that referenced
this pull request
Dec 20, 2022
* Updated doc for table format Enum
JoseJuan98
pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
* Updated doc for table format Enum
JoseJuan98
pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
* Updated doc for table format Enum
nmadan
pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
* Updated doc for table format Enum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Doc update for TableFormatEnum
Description of changes:
Doc update for TableFormatEnum
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.