Skip to content

feat: local download dir for Model and Estimator classes #3535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 47 commits into from
Closed

feat: local download dir for Model and Estimator classes #3535

wants to merge 47 commits into from

Conversation

evakravi
Copy link
Member

Issue #, if available:

Description of changes:
Adds local_download_dir argument to Estimator and Model classes. This allows users the ability to specify a directory for downloading temporary artifacts. This change was motivated by the need to use a non-default download location when using the SageMaker Python SDK in SageMaker Studio (disk space limit errors were experienced).

Testing done:
Added unit tests.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

NivekNey and others added 30 commits December 2, 2022 12:48
@NivekNey
fix: type hint of PySparkProcessor __init__ (aws#3297)
c97c467
@andre-marcos-perez
fix: fix PySparkProcessor __init__ params type (aws#3354)
de58941
@shreyapandit @mufaddal-rohawala
fix: Allow Py 3.7 for MMS Test Docker env (aws#3080)
41dd330 
Co-authored-by: Mufaddal Rohawala <[email protected]>
@maldil
refactoring : using with statement (aws#3286)
1e23a3f
@shreyapandit @BasilBeirouti @knikure
Update local_requirements.txt PyYAML version (aws#3095)
19efadf 
Co-authored-by: Basil Beirouti <[email protected]>
Co-authored-by: Kalyani Nikure <[email protected]>
@arjkesh
feature: Update TF 2.9 and TF 2.10 inference DLCs (aws#3465)
76f7782
@keshav-chandak
feature: Added transform with monitoring pipeline step in transformer (…
fde0738 
…aws#3438)

Co-authored-by: Keshav Chandak <[email protected]>
@claytonparnell
fix: Fix bug forcing uploaded tar to be named sourcedir (aws#3412)
7f9f3b0
@navinsoni @navinns
feature: Add Code Owners file (aws#3503)
5d59767 
Co-authored-by: Navin Soni <[email protected]>
prepare release v2.119.0
0f5cf18
update development version to v2.119.1.dev0
f1f0013
@RadhikaB-97
feature: Add DXB region to frameworks by DLC (aws#3387)
bb4b689 
* Add DXB region

* Remove change from neuron

* Adding DXB to TF 2.1.0 and 2.1.1
@brockwade633 @mufaddal-rohawala
fix: support idempotency for framework and spark processors (aws#3460)
b68bcd9 
Co-authored-by: Brock Wade <[email protected]>
Co-authored-by: Mufaddal Rohawala <[email protected]>
@kenny-ezirim
feature: Update registries with new region account number mappings. (a…
32969da 
…ws#3492)
@Lokiiiiii
feature: Adding support for SageMaker Training Compiler in PyTorch es…
767da0a 
…timator starting 1.12 (aws#3500)

Co-authored-by: Ubuntu <[email protected]>
@HappyAmazonian
feature: Add Neo image uri config for Pytorch 1.12 (aws#3507)
d779d1b
prepare release v2.120.0
83327fb
update development version to v2.120.1.dev0
5bffb04
@malav-shastri
feature: Algorithms Region Expansion OSU/DXB (aws#3508)
b828396 
Co-authored-by: Malav Shastri <[email protected]>
@navinsoni
fix: Add constraints file for apache-airflow (aws#3510)
357f732
@brockwade633 @mufaddal-rohawala
fix: FrameworkProcessor S3 uploads (aws#3493)
a28d1dd 
Co-authored-by: Brock Wade <[email protected]>
Co-authored-by: Mufaddal Rohawala <[email protected]>
prepare release v2.121.0
11d2475
update development version to v2.121.1.dev0
24171b5
@Lokiiiiii
Fix: Differentiate SageMaker Training Compiler's PT DLCs from base PT…
d5847d5 
… DLC (aws#3515)
@evakravi
fix: Fix failing jumpstart cache unit tests (aws#3514)
3f6ea88
@qidewenwhen
fix: Pop out ModelPackageName from pipeline definition (aws#3472)
4570aa6 
Co-authored-by: Dewen Qi <[email protected]>
prepare release v2.121.1
959ea1a
update development version to v2.121.2.dev0
b2e8b66
@amzn-choeric
fix: Skip Bad Transform Test (aws#3521)
355975d
@mufaddal-rohawala
fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
fadc817
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 094e476
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 0086f6b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 0086f6b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 0086f6b
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 0086f6b
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 0086f6b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 0086f6b
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 0086f6b
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 0086f6b
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 7ff0891
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 7ff0891
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 7ff0891
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 7ff0891
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 7ff0891
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 7ff0891
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 7ff0891
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 7ff0891
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: b6f9918
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: b6f9918
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: b6f9918
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: b6f9918
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: b6f9918
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

trajanikant
trajanikant reviewed Jan 18, 2023
View reviewed changes
Copy link
Contributor

@trajanikant trajanikant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run notebook-tests, slow-tests

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: b6f9918
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: b6f9918
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@evakravi evakravi mentioned this pull request Jan 18, 2023
Merged
9 tasks
@evakravi evakravi closed this Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trajanikant trajanikant trajanikant left review comments

@JGuinegagne JGuinegagne JGuinegagne approved these changes

@vikas0203 vikas0203 Awaiting requested review from vikas0203 vikas0203 is a code owner automatically assigned from aws/sagemaker-ml-frameworks

@mufaddal-rohawala mufaddal-rohawala Awaiting requested review from mufaddal-rohawala

Assignees

@vikas0203 vikas0203

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.