-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: Pop out ModelPackageName from pipeline definition #3472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Codecov Report
@@ Coverage Diff @@
## master #3472 +/- ##
==========================================
- Coverage 89.17% 88.82% -0.36%
==========================================
Files 204 205 +1
Lines 18979 19467 +488
==========================================
+ Hits 16924 17291 +367
- Misses 2055 2176 +121
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/bot run slow-tests
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Co-authored-by: Dewen Qi <[email protected]>
Co-authored-by: Dewen Qi <[email protected]>
Co-authored-by: Dewen Qi <[email protected]>
Co-authored-by: Dewen Qi <[email protected]>
Co-authored-by: Dewen Qi <[email protected]>
Co-authored-by: Dewen Qi <[email protected]>
Issue #, if available: If a user provide
model_package_name
to a ModelStep, the pipeline definition can be successfully generated but it will break the CreatePipeline call with the following error:The reason is the pipeline backend excludes this field from the API model.
Description of changes:
Testing done: unit test and integ test
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.