Skip to content

fix: Fix failing jumpstart cache unit tests #3514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 8, 2022
Merged

fix: Fix failing jumpstart cache unit tests #3514

merged 3 commits into from
Dec 8, 2022

Conversation

evakravi
Copy link
Member

@evakravi evakravi commented Dec 8, 2022

Issue #, if available:

Description of changes:
Packaging library changed the exception if a version is invalid. A custom try-except statement has been added to fix the exceptions returned.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@evakravi evakravi requested a review from a team as a code owner December 8, 2022 19:13
@evakravi evakravi requested review from navinsoni and removed request for a team December 8, 2022 19:13
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: d577e3e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2022 •
edited
Loading

Codecov Report

Merging #3514 (216cab7) into master (1fa2377) will decrease coverage by 0.30%.
The diff coverage is 87.55%.

@@            Coverage Diff             @@
##           master    #3514      +/-   ##
==========================================
- Coverage   89.17%   88.87%   -0.31%     
==========================================
  Files         204      213       +9     
  Lines       18979    20560    +1581     
==========================================
+ Hits        16924    18272    +1348     
- Misses       2055     2288     +233
Impacted Files Coverage Δ
src/sagemaker/feature_store/feature_group.py 76.52% <ø> (ø)
src/sagemaker/huggingface/model.py 89.87% <ø> (ø)
src/sagemaker/pipeline.py 85.33% <ø> (ø)
src/sagemaker/sklearn/model.py 92.98% <ø> (-1.76%) ⬇️
src/sagemaker/sparkml/model.py 100.00% <ø> (ø)
...sagemaker/workflow/monitor_batch_transform_step.py 0.00% <0.00%> (ø)
src/sagemaker/xgboost/model.py 96.36% <ø> (-1.82%) ⬇️
...agemaker/model_monitor/clarify_model_monitoring.py 89.84% <27.58%> (-5.09%) ⬇️
src/sagemaker/transformer.py 85.41% <40.62%> (-9.07%) ⬇️
.../sagemaker/huggingface/training_compiler/config.py 90.47% <50.00%> (ø)
... and 58 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: d577e3e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: b681d81
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: b681d81
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@knikure knikure self-assigned this Dec 8, 2022
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 216cab7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 216cab7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 216cab7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 216cab7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 216cab7
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@knikure knikure changed the title chore: fix failing jumpstart cache unit tests fix: Fix failing jumpstart cache unit tests Dec 8, 2022
@knikure knikure merged commit 3f6ea88 into aws:master Dec 8, 2022
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 216cab7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 216cab7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 216cab7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 216cab7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 216cab7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jmahlik jmahlik mentioned this pull request Dec 12, 2022
Closed
@claytonparnell claytonparnell mentioned this pull request Dec 13, 2022
Merged
9 tasks
mizanfiu pushed a commit to mizanfiu/sagemaker-python-sdk that referenced this pull request Dec 13, 2022
@evakravi @mizanfiu
fix: Fix failing jumpstart cache unit tests (aws#3514)
742301f
mufaddal-rohawala pushed a commit to mufaddal-rohawala/sagemaker-python-sdk that referenced this pull request Dec 19, 2022
@evakravi @mufiAmazon
fix: Fix failing jumpstart cache unit tests (aws#3514)
3b1cd36
mufaddal-rohawala pushed a commit that referenced this pull request Dec 20, 2022
@evakravi @mufiAmazon
fix: Fix failing jumpstart cache unit tests (#3514)
384742f
Shegufta pushed a commit to Shegufta/sagemaker-python-sdk that referenced this pull request Dec 21, 2022
@evakravi
fix: Fix failing jumpstart cache unit tests (aws#3514)
ca9f23b
JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023
@evakravi @JoseJuan98
fix: Fix failing jumpstart cache unit tests (aws#3514)
86c6d73
JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023
@evakravi @JoseJuan98
fix: Fix failing jumpstart cache unit tests (aws#3514)
07d2217
nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023
@evakravi
fix: Fix failing jumpstart cache unit tests (aws#3514)
974afa4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JGuinegagne JGuinegagne JGuinegagne approved these changes

@mufaddal-rohawala mufaddal-rohawala mufaddal-rohawala approved these changes

@navinsoni navinsoni Awaiting requested review from navinsoni navinsoni is a code owner automatically assigned from aws/sagemaker-ml-frameworks

Assignees

@knikure knikure

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@evakravi @sagemaker-bot @codecov-commenter @JGuinegagne @mufaddal-rohawala @knikure