infra: add py38 to buildspecs #1615

metrizable · 2020-06-22T17:18:48Z

Issue #, if available: #1592

Description of changes:

changes include:

include py38 in env list for unit and release buildspecs
upgrade py37 to py38 and Python 3.7 to Python 3.8 in integ and local-mode buildspecs

Testing done:

unit:

...
py27: commands succeeded
py36: commands succeeded
py37: commands succeeded
py38: commands succeeded
congratulations :)

[Container] 2020/06/22 15:30:39 Running command ./ci-scripts/displaytime.sh 'py27,py36,py37,py38 unit' $start_time
=================== py27,py36,py37,py38 unit execution time ===================
5 minutes and 31 seconds
...

integs:

...
[Container] 2020/06/22 16:05:32 Running command ./ci-scripts/displaytime.sh 'py27,py38 local mode' $start_time
=================== py27,py38 local mode execution time ===================
47 minutes and 12 seconds
 
 
[Container] 2020/06/22 16:05:32 Phase complete: BUILD State: SUCCEEDED
[Container] 2020/06/22 16:05:32 Phase context status code:  Message:
[Container] 2020/06/22 16:05:32 Entering phase POST_BUILD
[Container] 2020/06/22 16:05:32 Phase complete: POST_BUILD State: SUCCEEDED
[Container] 2020/06/22 16:05:32 Phase context status code:  Message:
...

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…es arg (aws#1608)

This commit also consolidates the doc dependencies to doc/requirements.txt, removes some unnecessary dependencies, and upgrades sphinx-rtd-theme to 0.5.0.

sagemaker-bot · 2020-06-22T17:20:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: d1e8951
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-22T17:32:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: d1e8951
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-22T18:04:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: d1e8951
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-22T18:13:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 64c7363
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-22T18:17:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: d1e8951
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-22T18:25:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 64c7363
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

metrizable · 2020-06-22T17:21:22Z

tests/integ/test_model_monitor.py

@@ -84,7 +84,7 @@

 INTEG_TEST_MONITORING_OUTPUT_BUCKET = "integ-test-monitoring-output-bucket"

-FIVE_MINUTE_CRON_EXPRESSION = "cron(0/5 * ? * * *)"


5 min is unsupported: https://docs.aws.amazon.com/sagemaker/latest/APIReference/API_ScheduleConfig.html

sagemaker-bot · 2020-06-22T19:14:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 64c7363
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-22T20:17:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 64c7363
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-22T20:27:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 64c7363
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

ci and others added 6 commits June 19, 2020 16:04

prepare release v1.65.1

84db74d

update development version to v1.65.2.dev0

b0024ce

doc: document that Local Mode + local code doesn't support dependenci…

71f43c5

…es arg (aws#1608)

infra: upgrade Sphinx to 3.1.1 (aws#1605)

1c3e74b

This commit also consolidates the doc dependencies to doc/requirements.txt, removes some unnecessary dependencies, and upgrades sphinx-rtd-theme to 0.5.0.

Merge remote-tracking branch 'aws/master' into include-py38-buildspecs

7f8baaf

feature: add py38 to buildspecs

d1e8951

Merge branch 'master' into include-py38-buildspecs

64c7363

metrizable commented Jun 22, 2020

View reviewed changes

ajaykarpur changed the title ~~feature: add py38 to buildspecs~~ infra: add py38 to buildspecs Jun 23, 2020

ajaykarpur approved these changes Jun 23, 2020

View reviewed changes

metrizable merged commit c919830 into aws:master Jun 23, 2020

metrizable deleted the include-py38-buildspecs branch June 26, 2020 05:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

infra: add py38 to buildspecs #1615

infra: add py38 to buildspecs #1615

metrizable commented Jun 22, 2020

sagemaker-bot commented Jun 22, 2020

sagemaker-bot commented Jun 22, 2020

sagemaker-bot commented Jun 22, 2020

sagemaker-bot commented Jun 22, 2020

sagemaker-bot commented Jun 22, 2020

sagemaker-bot commented Jun 22, 2020

metrizable Jun 22, 2020

sagemaker-bot commented Jun 22, 2020

sagemaker-bot commented Jun 22, 2020

sagemaker-bot commented Jun 22, 2020

		@@ -84,7 +84,7 @@

		INTEG_TEST_MONITORING_OUTPUT_BUCKET = "integ-test-monitoring-output-bucket"

		FIVE_MINUTE_CRON_EXPRESSION = "cron(0/5 * ? * * *)"

infra: add py38 to buildspecs #1615

infra: add py38 to buildspecs #1615

Conversation

metrizable commented Jun 22, 2020

Merge Checklist

General

Tests

sagemaker-bot commented Jun 22, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 22, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 22, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 22, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 22, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 22, 2020

AWS CodeBuild CI Report

metrizable Jun 22, 2020

Choose a reason for hiding this comment

sagemaker-bot commented Jun 22, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 22, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 22, 2020

AWS CodeBuild CI Report