Skip to content

Commit d1e8951

Browse files
committed
feature: add py38 to buildspecs
1 parent 7f8baaf commit d1e8951

5 files changed

+11
-11
lines changed

buildspec-localmodetests.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,5 @@ phases:
1111

1212
# local mode tests
1313
- start_time=`date +%s`
14-
- execute-command-if-has-matching-changes "tox -e py27,py37 -- tests/integ -m local_mode --durations 50" "tests/integ" "tests/data" "tests/conftest.py" "tests/__init__.py" "src/*.py" "setup.py" "setup.cfg" "buildspec-localmodetests.yml"
15-
- ./ci-scripts/displaytime.sh 'py27,py37 local mode' $start_time
14+
- execute-command-if-has-matching-changes "tox -e py27,py38 -- tests/integ -m local_mode --durations 50" "tests/integ" "tests/data" "tests/conftest.py" "tests/__init__.py" "src/*.py" "setup.py" "setup.cfg" "buildspec-localmodetests.yml"
15+
- ./ci-scripts/displaytime.sh 'py27,py38 local mode' $start_time

buildspec-release.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ phases:
1818
# run unit tests
1919
- AWS_ACCESS_KEY_ID= AWS_SECRET_ACCESS_KEY= AWS_SESSION_TOKEN=
2020
AWS_CONTAINER_CREDENTIALS_RELATIVE_URI= AWS_DEFAULT_REGION=
21-
tox -e py27,py36,py37 -- tests/unit
21+
tox -e py27,py36,py37,py38 -- tests/unit
2222

2323
# run a subset of the integration tests
2424
- IGNORE_COVERAGE=- tox -e py36 -- tests/integ -m canary_quick -n 64 --boxed --reruns 2

buildspec-unittests.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,5 +18,5 @@ phases:
1818
- start_time=`date +%s`
1919
- AWS_ACCESS_KEY_ID= AWS_SECRET_ACCESS_KEY= AWS_SESSION_TOKEN=
2020
AWS_CONTAINER_CREDENTIALS_RELATIVE_URI= AWS_DEFAULT_REGION=
21-
tox -e py27,py36,py37 --parallel all -- tests/unit
22-
- ./ci-scripts/displaytime.sh 'py27,py36,py37 unit' $start_time
21+
tox -e py27,py36,py37,py38 --parallel all -- tests/unit
22+
- ./ci-scripts/displaytime.sh 'py27,py36,py37,py38 unit' $start_time

buildspec.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,13 @@ phases:
1111

1212
# run integration tests
1313
- start_time=`date +%s`
14-
- execute-command-if-has-matching-changes "python3.7 -u ci-scripts/queue_build.py" "tests/integ" "tests/scripts" "tests/data" "tests/conftest.py" "tests/__init__.py" "src/*.py" "setup.py" "setup.cfg" "buildspec.yml"
14+
- execute-command-if-has-matching-changes "python3.8 -u ci-scripts/queue_build.py" "tests/integ" "tests/scripts" "tests/data" "tests/conftest.py" "tests/__init__.py" "src/*.py" "setup.py" "setup.cfg" "buildspec.yml"
1515
- ./ci-scripts/displaytime.sh 'build queue' $start_time
1616

1717
- start_time=`date +%s`
1818
- |
19-
execute-command-if-has-matching-changes "env -u AWS_DEFAULT_REGION tox -e py37 -- tests/integ -m \"not local_mode\" -n 512 --reruns 3 --reruns-delay 5 --durations 50 --boto-config '{\"region_name\": \"us-east-2\"}'" "tests/integ" "tests/scripts" "tests/data" "tests/conftest.py" "tests/__init__.py" "src/*.py" "setup.py" "setup.cfg" "buildspec.yml"
20-
- ./ci-scripts/displaytime.sh 'py37 tests/integ' $start_time
19+
execute-command-if-has-matching-changes "env -u AWS_DEFAULT_REGION tox -e py38 -- tests/integ -m \"not local_mode\" -n 512 --reruns 3 --reruns-delay 5 --durations 50 --boto-config '{\"region_name\": \"us-east-2\"}'" "tests/integ" "tests/scripts" "tests/data" "tests/conftest.py" "tests/__init__.py" "src/*.py" "setup.py" "setup.cfg" "buildspec.yml"
20+
- ./ci-scripts/displaytime.sh 'py38 tests/integ' $start_time
2121

2222
post_build:
2323
finally:

tests/integ/test_model_monitor.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@
8484

8585
INTEG_TEST_MONITORING_OUTPUT_BUCKET = "integ-test-monitoring-output-bucket"
8686

87-
FIVE_MINUTE_CRON_EXPRESSION = "cron(0/5 * ? * * *)"
87+
TWO_HOUR_CRON_EXPRESSION = "cron(0 0/2 ? * * *)"
8888

8989

9090
@pytest.fixture(scope="module")
@@ -150,7 +150,7 @@ def default_monitoring_schedule_name(sagemaker_session, output_kms_key, volume_k
150150
output_s3_uri=output_s3_uri,
151151
statistics=statistics,
152152
constraints=constraints,
153-
schedule_cron_expression=FIVE_MINUTE_CRON_EXPRESSION,
153+
schedule_cron_expression=TWO_HOUR_CRON_EXPRESSION,
154154
enable_cloudwatch_metrics=ENABLE_CLOUDWATCH_METRICS,
155155
)
156156

@@ -210,7 +210,7 @@ def byoc_monitoring_schedule_name(sagemaker_session, output_kms_key, volume_kms_
210210
output=MonitoringOutput(source="/opt/ml/processing/output", destination=output_s3_uri),
211211
statistics=statistics,
212212
constraints=constraints,
213-
schedule_cron_expression=FIVE_MINUTE_CRON_EXPRESSION,
213+
schedule_cron_expression=TWO_HOUR_CRON_EXPRESSION,
214214
)
215215

216216
_wait_for_schedule_changes_to_apply(monitor=my_byoc_monitor)

0 commit comments

Comments
 (0)