Skip to content

infra: upgrade Sphinx to 3.1.1 #1605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 18, 2020
Merged

infra: upgrade Sphinx to 3.1.1 #1605

merged 3 commits into from
Jun 18, 2020

Conversation

laurenyu
Copy link
Contributor

Issue #, if available:

Description of changes:
This PR does a few things:

  • upgrade Sphinx to 3.1.1 and sphinx-rtd-theme to 0.5.0 (the latest versions as of this writing)
  • consolidate the doc dependencies to doc/requirements.txt
  • remove some unnecessary dependencies

Testing done:

  • tox -e sphinx
  • built the docs locally

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@laurenyu
infra: upgrade Sphinx to 3.1.1
08531b0 
This commit also consolidates the doc dependencies to doc/requirements.txt,
removes some unnecessary dependencies, and upgrades sphinx-rtd-theme to 0.5.0.
@laurenyu laurenyu requested a review from aaronmarkham June 17, 2020 23:40
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 08531b0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 08531b0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 08531b0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

metrizable
metrizable previously approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@metrizable metrizable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it!

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 08531b0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aaronmarkham
aaronmarkham suggested changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@aaronmarkham aaronmarkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update this too?
https://github.com/aws/sagemaker-python-sdk/blame/master/README.rst#L173

@laurenyu
Copy link
Contributor Author

updated the README so that it no longer hardcodes a version and instead relies on the requirements.txt file

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 261f9e1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 261f9e1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 261f9e1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 261f9e1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

metrizable
metrizable approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@metrizable metrizable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: a3964f7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: a3964f7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: a3964f7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: a3964f7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@laurenyu laurenyu merged commit 875abe1 into aws:master Jun 18, 2020
@laurenyu laurenyu deleted the upgrade-sphinx branch June 18, 2020 19:59
metrizable pushed a commit to metrizable/sagemaker-python-sdk that referenced this pull request Jun 19, 2020
@laurenyu @metrizable
infra: upgrade Sphinx to 3.1.1 (aws#1605)
cd869a0 
This commit also consolidates the doc dependencies to doc/requirements.txt,
removes some unnecessary dependencies, and upgrades sphinx-rtd-theme to 0.5.0.
metrizable pushed a commit to metrizable/sagemaker-python-sdk that referenced this pull request Jun 19, 2020
@laurenyu @metrizable
infra: upgrade Sphinx to 3.1.1 (aws#1605)
1c3e74b 
This commit also consolidates the doc dependencies to doc/requirements.txt,
removes some unnecessary dependencies, and upgrades sphinx-rtd-theme to 0.5.0.
metrizable added a commit that referenced this pull request Jun 23, 2020
@metrizable @laurenyu
infra: add py38 to buildspecs (#1615)
c919830 
* prepare release v1.65.1

* update development version to v1.65.2.dev0

* doc: document that Local Mode + local code doesn't support dependencies arg (#1608)

* infra: upgrade Sphinx to 3.1.1 (#1605)

This commit also consolidates the doc dependencies to doc/requirements.txt,
removes some unnecessary dependencies, and upgrades sphinx-rtd-theme to 0.5.0.

* feature: add py38 to buildspecs

Co-authored-by: ci <ci>
Co-authored-by: Lauren Yu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronmarkham aaronmarkham aaronmarkham approved these changes

@metrizable metrizable metrizable approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laurenyu @sagemaker-bot @aaronmarkham @metrizable