fix: set logs to False if wait is False #1585

chuyang-deng · 2020-06-12T17:54:05Z

Issue #, if available:
#1584

Description of changes:
set logs to False when wait is False, instead of raising an error

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I used the commit message format described in CONTRIBUTING
I have passed the region in to any/all clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2020-06-12T18:06:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 6e5a794
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-12T18:22:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 6e5a794
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-12T18:45:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 6e5a794
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-12T18:51:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 6e5a794
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

laurenyu

unit test?

veerabio · 2020-06-14T01:14:18Z

src/sagemaker/automl/automl.py

-            logs (bool): Whether to show the logs produced by the job.
-                Only meaningful when wait is True (default: True).
+            logs (bool): Whether to show the logs produced by the job. Only meaningful when wait
+                is True (default: True). if `wait` is False, `log` will be set to False as well.


typo: logs missing s
if wait is False, log**s** will be set to False as well.

Thanks! updated!

… True

metrizable · 2020-06-15T19:28:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: c066263
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-15T19:32:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: c066263
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

chuyang-deng · 2020-06-15T19:36:33Z

unit test?

I updated the test (also add a message to warn that logs is going to be set to False when wait is False but logs is True)

sagemaker-bot · 2020-06-15T19:47:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 60464de
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-15T19:48:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 30092da
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-15T19:56:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: c066263
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-15T20:01:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 60464de
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-15T20:03:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 30092da
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-15T20:25:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: c066263
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-15T20:25:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 30092da
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-15T20:31:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 30092da
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-15T20:31:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 60464de
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

laurenyu · 2020-06-15T20:44:35Z

src/sagemaker/automl/automl.py

+            logs (bool): Whether to show the logs produced by the job. Only meaningful when wait
+                is True (default: True). if `wait` is False, `logs` will be set to False as well.


nit: need two backticks for formatting

laurenyu · 2020-06-15T20:45:04Z

src/sagemaker/automl/automl.py

-            )
+        if not wait and logs:
+            logs = False
+            logger.warning("logs will be set to False. logs is only meaningful when wait is True.")


s/logs will be set/Setting logs

laurenyu · 2020-06-15T20:48:38Z

tests/unit/sagemaker/automl/test_auto_ml.py

@@ -348,6 +348,7 @@ def test_auto_ml_additional_optional_params(sagemaker_session):
        "generate_candidate_definitions_only": GENERATE_CANDIDATE_DEFINITIONS_ONLY,
        "tags": TAGS,
    }
+    assert "logs will be set to False. logs is only meaningful when wait is True." in caplog.text


in addition to testing for the log output, you could patch("sagemaker.automl.AutoMLJob.start_new") and then call .wait.assert_not_called() on the resulting mock

added a new test instead to test warning messages and assert_not_called()

sagemaker-bot · 2020-06-15T23:13:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: b8e8d61
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-15T23:24:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 1de42cb
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-15T23:28:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: b8e8d61
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-15T23:46:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 1de42cb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-15T23:58:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: b8e8d61
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-16T00:17:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 1de42cb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-16T00:27:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 1de42cb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-16T05:31:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 151e24c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-16T05:53:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 151e24c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-16T05:57:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 151e24c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-16T06:23:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 151e24c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-16T18:42:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 1401351
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-16T18:56:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 1401351
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-16T19:04:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 1401351
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-16T19:29:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 1401351
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-16T22:27:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 99e07f9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-16T22:41:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 99e07f9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-16T23:10:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 99e07f9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-16T23:18:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 99e07f9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-16T23:32:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 43dea22
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-16T23:46:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 43dea22
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-17T00:15:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 43dea22
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-17T00:16:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 43dea22
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

fix: set logs to False if wait is False

6e5a794

laurenyu reviewed Jun 12, 2020

View reviewed changes

veerabio reviewed Jun 14, 2020

View reviewed changes

Chuyang Deng added 2 commits June 15, 2020 12:02

update unit test to test not raising error when wait is False logs is…

7751e62

… True

add warning

c066263

Chuyang Deng and others added 2 commits June 15, 2020 12:33

black check

60464de

Merge branch 'master' into auto-ml

30092da

laurenyu reviewed Jun 15, 2020

View reviewed changes

test wait not called

b8e8d61

update warning message

1de42cb

fix pylint error

151e24c

remove trailing whitespace

1401351

laurenyu approved these changes Jun 16, 2020

View reviewed changes

Merge branch 'master' into auto-ml

99e07f9

Merge branch 'master' into auto-ml

43dea22

laurenyu merged commit 875744a into aws:master Jun 17, 2020

laurenyu mentioned this pull request Jun 17, 2020

AutoML.fit(wait=False) requires explicit logs=False #1584

Closed

		logs (bool): Whether to show the logs produced by the job. Only meaningful when wait
		is True (default: True). if `wait` is False, `logs` will be set to False as well.

fix: set logs to False if wait is False #1585

fix: set logs to False if wait is False #1585

Conversation

chuyang-deng commented Jun 12, 2020

Merge Checklist

General

Tests

sagemaker-bot commented Jun 12, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 12, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 12, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 12, 2020

AWS CodeBuild CI Report

laurenyu left a comment

Choose a reason for hiding this comment

veerabio Jun 14, 2020

Choose a reason for hiding this comment

chuyang-deng Jun 15, 2020

Choose a reason for hiding this comment

metrizable commented Jun 15, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 15, 2020

AWS CodeBuild CI Report

chuyang-deng commented Jun 15, 2020

sagemaker-bot commented Jun 15, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 15, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 15, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 15, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 15, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 15, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 15, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 15, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 15, 2020

AWS CodeBuild CI Report

laurenyu Jun 15, 2020

Choose a reason for hiding this comment

laurenyu Jun 15, 2020

Choose a reason for hiding this comment

laurenyu Jun 15, 2020

Choose a reason for hiding this comment

chuyang-deng Jun 15, 2020

Choose a reason for hiding this comment

sagemaker-bot commented Jun 15, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 15, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 15, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 15, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 15, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 16, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 16, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 16, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 16, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 16, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 16, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 16, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 16, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 16, 2020

AWS CodeBuild CI Report